Fails glLinkProgram if two glBindAttribLocation conflicts.

Fails glLinkProgram if two glBindAttribLocation conflicts.

i.e., two declared attributes are bound to the same location, then we fail the link.

Many drivers already do this, but not all of them.  For example, mesa does not, and it caused memory corruption actually.  So we do this in chrome command buffer.

BUG=112569
TEST=test case in 112569
R=gman
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124707

[Zhenyao Mo, 2012-03-01 19:54:28]

Please review.

[greggman, 2012-03-01 22:49:36]

can you add a unit test?

https://chromiumcodereview.appspot.com/9570023/diff/1005/gpu/command_buffer/s...
File gpu/command_buffer/service/program_manager.cc (right):

https://chromiumcodereview.appspot.com/9570023/diff/1005/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager.cc:450: std::map<GLint, int>
location_binding_count;
could this just be std::set<GLint>?

https://chromiumcodereview.appspot.com/9570023/diff/1005/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager.cc:464: if (active) {
If location_binding_count is a set then this would just be

std::pair<std::set<GLint> >::iterator, bool> result =
  location_binding_used_.insert(it->second);
if (result.second) {
  return true;
}

[Zhenyao Mo, 2012-03-02 00:40:27]

Revised and added a unit test.  Please have another look.

[greggman, 2012-03-02 01:32:36]

lgtm

though it seems like a unit test that calls ProgramManager::Link would be good

https://chromiumcodereview.appspot.com/9570023/diff/7001/gpu/command_buffer/s...
File gpu/command_buffer/service/program_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/9570023/diff/7001/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager_unittest.cc:974: // Set up prgram
prgram->program

[Zhenyao Mo, 2012-03-02 18:58:21]

Updated the unittest to do Link()

https://chromiumcodereview.appspot.com/9570023/diff/7001/gpu/command_buffer/s...
File gpu/command_buffer/service/program_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/9570023/diff/7001/gpu/command_buffer/s...
gpu/command_buffer/service/program_manager_unittest.cc:974: // Set up prgram
On 2012/03/02 01:32:36, greggman wrote:
> prgram->program

Done.