Fix Bluetooth list redraw issues.

Fix Bluetooth list redraw issues.

BUG=none
TEST=Launch ChromeOS and enable Bluetooth in about://flags. Open chrome settings and ensure that the view is expanded to show advanced settings.   Click "Enable Bluetooth" and "Add a device".  Ensure that available Bluetooth devices are shown.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124864

[kevers, 2012-03-02 15:51:05]

Hi Chris,

Can you please have a look at this CL.  It fixes rendering glitches that occur
when an element is added to a list while it is hidden.  These elements are not
properly displayed when the list becomes visible.  Also addresses, potential
missing names for Bluetooth devices.

[keybuk, 2012-03-02 15:58:02]

https://chromiumcodereview.appspot.com/9570018/diff/4001/chrome/browser/resou...
File chrome/browser/resources/options2/chromeos/bluetooth_device_list.js
(right):

https://chromiumcodereview.appspot.com/9570018/diff/4001/chrome/browser/resou...
chrome/browser/resources/options2/chromeos/bluetooth_device_list.js:143: }
This is dealt with in the BluetoothDevice C++ now, could we drop it from here?

https://chromiumcodereview.appspot.com/9570018/diff/4001/chrome/browser/resou...
chrome/browser/resources/options2/chromeos/bluetooth_device_list.js:239: },
The 'icon' property has been dropped from the C++ code, so this won't do
anything except maybe error...

[kevers, 2012-03-02 16:24:39]

Since the 'icon' property is being dropped, we also need to drop the isSupported
method and handle device filtering from the C++ side.

https://chromiumcodereview.appspot.com/9570018/diff/4001/chrome/browser/resou...
File chrome/browser/resources/options2/chromeos/bluetooth_device_list.js
(right):

https://chromiumcodereview.appspot.com/9570018/diff/4001/chrome/browser/resou...
chrome/browser/resources/options2/chromeos/bluetooth_device_list.js:143: }
On 2012/03/02 15:58:02, keybuk wrote:
> This is dealt with in the BluetoothDevice C++ now, could we drop it from here?

Done.

https://chromiumcodereview.appspot.com/9570018/diff/4001/chrome/browser/resou...
chrome/browser/resources/options2/chromeos/bluetooth_device_list.js:239: },
On 2012/03/02 15:58:02, keybuk wrote:
> The 'icon' property has been dropped from the C++ code, so this won't do
> anything except maybe error...

Done.

[keybuk, 2012-03-02 16:26:31]

lgtm

[csilv, 2012-03-02 22:08:53]

lgtm

[commit-bot: I haz the power, 2012-03-02 23:13:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/9570018/8001

[commit-bot: I haz the power, 2012-03-03 04:30:43]

Try job failure for 9570018-8001 (retry) (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-03 13:43:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/9570018/8001

[commit-bot: I haz the power, 2012-03-03 16:25:18]

Change committed as 124864