Revert "Rename blahHandler to onBlah throughout dart:io."

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 342 matching lines @@
 
   void runCommand(Command command,
                   void exitHandler(int exitCode)) {
     if (new Platform().operatingSystem() == 'windows') {
       // Windows can't handle the first command if it is a .bat file or the like
       // with the slashes going the other direction.
       // TODO(efortuna): Remove this when fixed (Issue 1306).
       command.executable = command.executable.replaceAll('/', '\\');
     }
     process = new Process.start(command.executable, command.arguments);
-    process.onExit = exitHandler;
+    process.exitHandler = exitHandler;
     startTime = new Date.now();
     InputStream stdoutStream = process.stdout;
     InputStream stderrStream = process.stderr;
     StringInputStream stdoutStringStream = new StringInputStream(stdoutStream);
     StringInputStream stderrStringStream = new StringInputStream(stderrStream);
-    stdoutStringStream.onLine =
+    stdoutStringStream.lineHandler =
         makeReadHandler(stdoutStringStream, stdout);
-    stderrStringStream.onLine =
+    stderrStringStream.lineHandler =
         makeReadHandler(stderrStringStream, stderr);
     timeoutTimer = new Timer(timeoutHandler, 1000 * testCase.timeout);
   }
 
   void timeoutHandler(Timer unusedTimer) {
     timedOut = true;
     process.kill();
   }
 }
 
@@ skipping 28 matching lines @@
       // Start process if not yet started.
       _executable = testCase.commands.last().executable;
       _startProcess(() {
         doStartTest(testCase);
       });
     } else if (testCase.commands.last().executable != _executable) {
       // Restart this runner with the right executable for this test
       // if needed.
       _executable = testCase.commands.last().executable;
       _batchArguments = testCase.batchRunnerArguments;
-      _process.onExit = (exitCode) {
+      _process.exitHandler = (exitCode) {
         _process.close();
         _startProcess(() {
           doStartTest(testCase);
         });
       };
       _process.kill();
     } else {
       doStartTest(testCase);
     }
   }
 
   void terminate() {
     if (_process !== null) {
       bool closed = false;
-      _process.onExit = (exitCode) {
+      _process.exitHandler = (exitCode) {
         closed = true;
         _process.close();
       };
       if (_isWebDriver) {
         // Use a graceful shutdown so our Selenium script can close
         // the open browser processes. TODO(jmesserly): Send a signal once
         // that's supported, see dartbug.com/1756.
         _process.stdin.write('--terminate\n'.charCodes());
 
         // In case the run_selenium process didn't close, kill it after 30s
         bool shutdownMillisecs = 30000;
         new Timer((e) { if (!closed) _process.kill(); }, shutdownMillisecs);
       } else {
         _process.kill();
       }
     }
   }
 
   void doStartTest(TestCase testCase) {
     _startTime = new Date.now();
     _testStdout = new List<String>();
     _testStderr = new List<String>();
     _stderrDrained = false;
-    _stdoutStream.onLine = _readStdout(_stdoutStream, _testStdout);
-    _stderrStream.onLine = _readStderr(_stderrStream, _testStderr);
+    _stdoutStream.lineHandler = _readStdout(_stdoutStream, _testStdout);
+    _stderrStream.lineHandler = _readStderr(_stderrStream, _testStderr);
     _timer = new Timer(_timeoutHandler, testCase.timeout * 1000);
     var line = _createArgumentsLine(testCase.batchTestArguments);
     _process.stdin.write(line.charCodes());
   }
 
   String _createArgumentsLine(List<String> arguments) {
     return Strings.join(arguments, ' ') + '\n';
   }
 
   void _testCompleted() {
@@ skipping 62 matching lines @@
 
   void _exitHandler(exitCode) {
     if (_timer != null) _timer.cancel();
     _process.close();
     _startProcess(() {
       _reportResult(">>> TEST CRASH");
     });
   }
 
   void _timeoutHandler(ignore) {
-    _process.onExit = (exitCode) {
+    _process.exitHandler = (exitCode) {
       _process.close();
       _startProcess(() {
         _reportResult(">>> TEST TIMEOUT");
       });
     };
     _process.kill();
   }
 
   void _startProcess(then) {
     _process = new Process.start(_executable, _batchArguments);
     _stdoutStream = new StringInputStream(_process.stdout);
     _stderrStream = new StringInputStream(_process.stderr);
     _testStdout = new List<String>();
     _testStderr = new List<String>();
     _stderrDrained = false;
-    _stdoutStream.onLine = _readStdout(_stdoutStream, _testStdout);
-    _stderrStream.onLine = _readStderr(_stderrStream, _testStderr);
-    _process.onExit = _exitHandler;
-    _process.onStart = then;
+    _stdoutStream.lineHandler = _readStdout(_stdoutStream, _testStdout);
+    _stderrStream.lineHandler = _readStderr(_stderrStream, _testStderr);
+    _process.exitHandler = _exitHandler;
+    _process.startHandler = then;
   }
 }
 
 /**
  * ProcessQueue is the master control class, responsible for running all
  * the tests in all the TestSuites that have been registered.  It includes
  * a rate-limited queue to run a limited number of tests in parallel,
  * a ProgressIndicator which prints output when tests are started and
  * and completed, and a summary report when all tests are completed,
  * and counters to determine when all of the tests in all of the test suites
@@ skipping 92 matching lines @@
       Process process = null;
       if (new Platform().operatingSystem() == 'windows') {
         process = new Process.start(
             'C:\\Windows\\System32\\taskkill.exe', ['/F', '/IM', name + '.exe',
             '/T']);
       } else {
         process = new Process.start('killall', ['-9', name]);
       }
 
       if (name == processNames[browserUsed].last()) {
-        process.onExit = (exitCode) {
+        process.exitHandler = (exitCode) {
           process.close();
           _progress.allDone();
         };
-        process.onError = (error) {
+        process.errorHandler = (error) {
           _progress.allDone();
         };
       } else {
-        process.onExit = (exitCode) {
+        process.exitHandler = (exitCode) {
           process.close();
         };
       }
     }
   }
 
   /**
    * Perform any cleanup needed once all tests in a TestSuite have completed
    * and notify our progress indicator that we are done.
    */
@@ skipping 17 matching lines @@
         } else if (!_temporaryDirectory.startsWith('/tmp/') ||
                    _temporaryDirectory.contains('/../')) {
           // Let's be extra careful, since rm -rf is so dangerous.
           print('Temporary directory $_temporaryDirectory unsafe to delete!');
           _cleanupAndMarkDone();
         } else {
           // TODO(dart:1211): Use delete(recursive=true) in Dart when it is
           // implemented, and add Windows support.
           var deletion =
               new Process.start('/bin/rm', ['-rf', _temporaryDirectory]);
-          deletion.onExit = (int exitCode) {
+          deletion.exitHandler = (int exitCode) {
             if (exitCode == 0) {
               if (!_listTests) {  // Output of --list option is used by scripts.
                 print('\nTemporary directory $_temporaryDirectory deleted.');
               }
             } else {
               print('\nDeletion of temp dir $_temporaryDirectory failed.');
             }
             _cleanupAndMarkDone();
           };
         }
@@ skipping 69 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }