Ensure blobs and associated temp/shareable files survive URLRequest uploads.

Ensure blobs and associated temp/shareable files survive URLRequest uploads.

BUG=115603
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124581

[michaeln, 2012-03-01 22:22:56]

ptal

[willchan no longer on Chromium, 2012-03-01 22:39:45]

Can you tell me what the long-term plan is for blob data handling in UploadData?
The whole thing about UploadData needing to know about WebKit blobs is a
layering violation. Will we be able to get rid of this in the new
UploadDataStream interface world? It looks weird that UploadData supports
UserData. Is this a transitory state or a long-term addition?

[michaeln, 2012-03-01 22:50:27]

On 2012/03/01 22:39:45, willchan wrote:
> Can you tell me what the long-term plan is for blob data handling in
UploadData?

If you can tell me what the long-term plan is with regard to URLRequest upload
api, i'd be happy to :)

I hope and expect this is transitory. Presuming the caller could pass in a
derivative of an 'UploadDataStream' class, that derivative would be able to
manage state like this.

Personally, I would like to the existing UploadData class removed from the
project entirely when the URLRequest interface gets cleaned up. This data
structure is also oddly within IPC messages related to uploading. That usage
probably should be replaced by a webkit_glue layer data structure.

[willchan no longer on Chromium, 2012-03-01 22:57:23]

LGTM, as I agree with everything you just said. Please add comments so others
don't think about using this, although I doubt that anyone would.

https://chromiumcodereview.appspot.com/9569035/diff/2008/net/base/upload_data.h
File net/base/upload_data.h (right):

https://chromiumcodereview.appspot.com/9569035/diff/2008/net/base/upload_data...
net/base/upload_data.h:38: public base::SupportsUserData {
It'd be great to add comments for what this is used for, and to indicate that
it's temporary.

[kinuko, 2012-03-02 01:47:32]

lgtm2 (if net/ change looks good to willchan)

On 2012/03/01 22:57:23, willchan wrote:
> LGTM, as I agree with everything you just said. Please add comments so others
> don't think about using this, although I doubt that anyone would.
> 
>
https://chromiumcodereview.appspot.com/9569035/diff/2008/net/base/upload_data.h
> File net/base/upload_data.h (right):
> 
>
https://chromiumcodereview.appspot.com/9569035/diff/2008/net/base/upload_data...
> net/base/upload_data.h:38: public base::SupportsUserData {
> It'd be great to add comments for what this is used for, and to indicate that
> it's temporary.

[michaeln, 2012-03-02 02:23:58]

https://chromiumcodereview.appspot.com/9569035/diff/2008/net/base/upload_data.h
File net/base/upload_data.h (right):

https://chromiumcodereview.appspot.com/9569035/diff/2008/net/base/upload_data...
net/base/upload_data.h:38: public base::SupportsUserData {
On 2012/03/01 22:57:23, willchan wrote:
> It'd be great to add comments for what this is used for, and to indicate that
> it's temporary.

Done.