Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: Source/WebCore/rendering/RenderBlock.cpp

Issue 9569026: Merge 107987 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/multicol/span/table-multi-column-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 return; 421 return;
422 } 422 }
423 423
424 RenderBlock* RenderBlock::containingColumnsBlock(bool allowAnonymousColumnBlock) 424 RenderBlock* RenderBlock::containingColumnsBlock(bool allowAnonymousColumnBlock)
425 { 425 {
426 RenderBlock* firstChildIgnoringAnonymousWrappers = 0; 426 RenderBlock* firstChildIgnoringAnonymousWrappers = 0;
427 for (RenderObject* curr = this; curr; curr = curr->parent()) { 427 for (RenderObject* curr = this; curr; curr = curr->parent()) {
428 if (!curr->isRenderBlock() || curr->isFloatingOrPositioned() || curr->is TableCell() || curr->isRoot() || curr->isRenderView() || curr->hasOverflowClip() 428 if (!curr->isRenderBlock() || curr->isFloatingOrPositioned() || curr->is TableCell() || curr->isRoot() || curr->isRenderView() || curr->hasOverflowClip()
429 || curr->isInlineBlockOrInlineTable()) 429 || curr->isInlineBlockOrInlineTable())
430 return 0; 430 return 0;
431
432 // FIXME: Table manages its own table parts, most of which are RenderBox es.
433 // Multi-column code cannot handle splitting the flow in table. Disablin g it
434 // to prevent crashes.
435 if (curr->isTable())
436 return 0;
431 437
432 RenderBlock* currBlock = toRenderBlock(curr); 438 RenderBlock* currBlock = toRenderBlock(curr);
433 if (!currBlock->createsAnonymousWrapper()) 439 if (!currBlock->createsAnonymousWrapper())
434 firstChildIgnoringAnonymousWrappers = currBlock; 440 firstChildIgnoringAnonymousWrappers = currBlock;
435 441
436 if (currBlock->style()->specifiesColumns() && (allowAnonymousColumnBlock || !currBlock->isAnonymousColumnsBlock())) 442 if (currBlock->style()->specifiesColumns() && (allowAnonymousColumnBlock || !currBlock->isAnonymousColumnsBlock()))
437 return firstChildIgnoringAnonymousWrappers; 443 return firstChildIgnoringAnonymousWrappers;
438 444
439 if (currBlock->isAnonymousColumnSpanBlock()) 445 if (currBlock->isAnonymousColumnSpanBlock())
440 return 0; 446 return 0;
(...skipping 6635 matching lines...) Expand 10 before | Expand all | Expand 10 after
7076 } 7082 }
7077 7083
7078 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject) 7084 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject)
7079 { 7085 {
7080 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x( ), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY()); 7086 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x( ), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY());
7081 } 7087 }
7082 7088
7083 #endif 7089 #endif
7084 7090
7085 } // namespace WebCore 7091 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/multicol/span/table-multi-column-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698