Chromium Code Reviews
Help | Chromium Project | Sign in
(803)

Issue 9568041: Fix flakiness of the TestFailedChannelAuth unittest. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Sergey Ulanov
Modified:
2 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews_chromium.org, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix flakiness of the TestFailedChannelAuth unittest.

The problem was that in some case the client would destroy the channel before
it sends auth byte to the host, and the host would still try to connect the
channel indefinetly.

BUG=116431
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124574

Patch Set 1 : - #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Lint Patch
M remoting/protocol/jingle_session_unittest.cc View 1 6 chunks +26 lines, -13 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 5
Sergey Ulanov
2 years, 1 month ago #1
Wez
lgtm
2 years, 1 month ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9568041/1001
2 years, 1 month ago #3
I haz the power (commit-bot)
Try job failure for 9568041-1001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
2 years, 1 month ago #4
I haz the power (commit-bot)
2 years, 1 month ago #5
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6