Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(764)

Issue 9568041: Fix flakiness of the TestFailedChannelAuth unittest. (Closed)

Created:
6 years, 1 month ago by Sergey Ulanov
Modified:
6 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix flakiness of the TestFailedChannelAuth unittest. The problem was that in some case the client would destroy the channel before it sends auth byte to the host, and the host would still try to connect the channel indefinetly. BUG=116431 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124574

Patch Set 1 : - #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M remoting/protocol/jingle_session_unittest.cc View 1 6 chunks +26 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
6 years, 1 month ago (2012-03-01 23:04:26 UTC) #1
Wez
lgtm
6 years, 1 month ago (2012-03-01 23:07:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9568041/1001
6 years, 1 month ago (2012-03-01 23:07:54 UTC) #3
commit-bot: I haz the power
Try job failure for 9568041-1001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
6 years, 1 month ago (2012-03-01 23:46:50 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2012-03-01 23:57:40 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698