Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 9568038: Implement the auto-logout on idle feature for Kiosk mode. (Closed)

Created:
8 years, 9 months ago by rkc
Modified:
8 years, 9 months ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, zel
Visibility:
Public.

Description

Implement the auto-logout on idle feature for Kiosk mode. This CL implements the auto-logout feature for Kiosk mode. The timeouts are pulled from the kiosk_mode_helper class. This CL implements parts of the code for http://codereview.chromium.org/9265026/ Though this code is vastly refactored and reduced. R=xiyuan@chromium.org BUG=chromium-os:26045 TEST=Tested with the flag to ensure the feature works correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124799

Patch Set 1 #

Total comments: 8

Patch Set 2 : clang build fix #

Patch Set 3 : Review changes. #

Total comments: 8

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Total comments: 4

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_helper.cc View 2 chunks +16 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.h View 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc View 1 2 1 chunk +99 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout_unittest.cc View 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 2 chunks +0 lines, -6 lines 0 comments Download
A chrome/browser/resources/chromeos/idle_logout_dialog.css View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/idle_logout_dialog.html View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/idle_logout_dialog.js View 1 2 3 4 5 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/idle_logout_dialog.h View 1 chunk +61 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/idle_logout_dialog.cc View 1 2 1 chunk +201 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rkc
8 years, 9 months ago (2012-03-01 21:59:57 UTC) #1
rkc
On 2012/03/01 21:59:57, Rahul Chaturvedi wrote: Added arv@ for OWNERS review needed for, chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
8 years, 9 months ago (2012-03-01 22:20:32 UTC) #2
xiyuan
LGTM with nits https://chromiumcodereview.appspot.com/9568038/diff/1/chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc File chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc (right): https://chromiumcodereview.appspot.com/9568038/diff/1/chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc#newcode14 chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc:14: #include "chrome/browser/ui/browser_dialogs.h" nit: Do you still ...
8 years, 9 months ago (2012-03-01 23:15:55 UTC) #3
rkc
https://chromiumcodereview.appspot.com/9568038/diff/1/chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc File chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc (right): https://chromiumcodereview.appspot.com/9568038/diff/1/chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc#newcode14 chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout.cc:14: #include "chrome/browser/ui/browser_dialogs.h" On 2012/03/01 23:15:56, xiyuan wrote: > nit: ...
8 years, 9 months ago (2012-03-02 00:10:19 UTC) #4
arv (Not doing code reviews)
https://chromiumcodereview.appspot.com/9568038/diff/4004/chrome/browser/resources/chromeos/idle_logout_dialog.html File chrome/browser/resources/chromeos/idle_logout_dialog.html (right): https://chromiumcodereview.appspot.com/9568038/diff/4004/chrome/browser/resources/chromeos/idle_logout_dialog.html#newcode5 chrome/browser/resources/chromeos/idle_logout_dialog.html:5: <title></title> Why the empty title? https://chromiumcodereview.appspot.com/9568038/diff/4004/chrome/browser/resources/chromeos/idle_logout_dialog.js File chrome/browser/resources/chromeos/idle_logout_dialog.js (right): ...
8 years, 9 months ago (2012-03-02 00:15:33 UTC) #5
rkc
https://chromiumcodereview.appspot.com/9568038/diff/4004/chrome/browser/resources/chromeos/idle_logout_dialog.html File chrome/browser/resources/chromeos/idle_logout_dialog.html (right): https://chromiumcodereview.appspot.com/9568038/diff/4004/chrome/browser/resources/chromeos/idle_logout_dialog.html#newcode5 chrome/browser/resources/chromeos/idle_logout_dialog.html:5: <title></title> On 2012/03/02 00:15:33, arv wrote: > Why the ...
8 years, 9 months ago (2012-03-02 01:20:55 UTC) #6
arv (Not doing code reviews)
https://chromiumcodereview.appspot.com/9568038/diff/2005/chrome/browser/resources/chromeos/idle_logout_dialog.js File chrome/browser/resources/chromeos/idle_logout_dialog.js (right): https://chromiumcodereview.appspot.com/9568038/diff/2005/chrome/browser/resources/chromeos/idle_logout_dialog.js#newcode24 chrome/browser/resources/chromeos/idle_logout_dialog.js:24: var currentTime = getMillisecondsSinceEpoch(); replace with Date.now()
8 years, 9 months ago (2012-03-02 02:26:20 UTC) #7
rkc
https://chromiumcodereview.appspot.com/9568038/diff/2005/chrome/browser/resources/chromeos/idle_logout_dialog.js File chrome/browser/resources/chromeos/idle_logout_dialog.js (right): https://chromiumcodereview.appspot.com/9568038/diff/2005/chrome/browser/resources/chromeos/idle_logout_dialog.js#newcode24 chrome/browser/resources/chromeos/idle_logout_dialog.js:24: var currentTime = getMillisecondsSinceEpoch(); On 2012/03/02 02:26:20, arv wrote: ...
8 years, 9 months ago (2012-03-02 03:03:21 UTC) #8
arv (Not doing code reviews)
http://codereview.chromium.org/9568038/diff/60/chrome/browser/resources/chromeos/idle_logout_dialog.js File chrome/browser/resources/chromeos/idle_logout_dialog.js (right): http://codereview.chromium.org/9568038/diff/60/chrome/browser/resources/chromeos/idle_logout_dialog.js#newcode16 chrome/browser/resources/chromeos/idle_logout_dialog.js:16: var currentTime = Date.Now(); Date.now() Maybe you should add ...
8 years, 9 months ago (2012-03-02 21:01:21 UTC) #9
rkc
http://codereview.chromium.org/9568038/diff/60/chrome/browser/resources/chromeos/idle_logout_dialog.js File chrome/browser/resources/chromeos/idle_logout_dialog.js (right): http://codereview.chromium.org/9568038/diff/60/chrome/browser/resources/chromeos/idle_logout_dialog.js#newcode16 chrome/browser/resources/chromeos/idle_logout_dialog.js:16: var currentTime = Date.Now(); On 2012/03/02 21:01:21, arv wrote: ...
8 years, 9 months ago (2012-03-02 21:47:08 UTC) #10
arv (Not doing code reviews)
LGTM
8 years, 9 months ago (2012-03-02 22:00:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/9568038/9001
8 years, 9 months ago (2012-03-02 22:06:28 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 01:00:39 UTC) #13
Change committed as 124799

Powered by Google App Engine
This is Rietveld 408576698