Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: Source/WebCore/svg/animation/SVGSMILElement.cpp

Issue 9568029: Merge 109345 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/svg/animations/smil-element-target-crash-main-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 } 193 }
194 } 194 }
195 195
196 void SVGSMILElement::removedFromDocument() 196 void SVGSMILElement::removedFromDocument()
197 { 197 {
198 m_attributeName = anyQName(); 198 m_attributeName = anyQName();
199 if (m_timeContainer) { 199 if (m_timeContainer) {
200 m_timeContainer->unschedule(this); 200 m_timeContainer->unschedule(this);
201 m_timeContainer = 0; 201 m_timeContainer = 0;
202 } 202 }
203 if (m_targetElement) {
204 document()->accessSVGExtensions()->removeAnimationElementFromTarget(this , m_targetElement);
205 m_targetElement = 0;
206 }
207 // Calling disconnectConditions() may kill us if there are syncbase conditio ns. 203 // Calling disconnectConditions() may kill us if there are syncbase conditio ns.
208 // OK, but we don't want to die inside the call. 204 // OK, but we don't want to die inside the call.
209 RefPtr<SVGSMILElement> keepAlive(this); 205 RefPtr<SVGSMILElement> keepAlive(this);
210 disconnectConditions(); 206 disconnectConditions();
207
208 // Clear target now, because disconnectConditions calls targetElement() whic h will recreate the target if we removed it sooner.
209 if (m_targetElement) {
210 document()->accessSVGExtensions()->removeAnimationElementFromTarget(this , m_targetElement);
211 m_targetElement = 0;
212 }
213
211 SVGElement::removedFromDocument(); 214 SVGElement::removedFromDocument();
212 } 215 }
213 216
214 SMILTime SVGSMILElement::parseOffsetValue(const String& data) 217 SMILTime SVGSMILElement::parseOffsetValue(const String& data)
215 { 218 {
216 bool ok; 219 bool ok;
217 double result = 0; 220 double result = 0;
218 String parse = data.stripWhiteSpace(); 221 String parse = data.stripWhiteSpace();
219 if (parse.endsWith("h")) 222 if (parse.endsWith("h"))
220 result = parse.left(parse.length() - 1).toDouble(&ok) * 60 * 60; 223 result = parse.left(parse.length() - 1).toDouble(&ok) * 60 * 60;
(...skipping 811 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 1035
1033 void SVGSMILElement::beginByLinkActivation() 1036 void SVGSMILElement::beginByLinkActivation()
1034 { 1037 {
1035 SMILTime elapsed = this->elapsed(); 1038 SMILTime elapsed = this->elapsed();
1036 addBeginTime(elapsed, elapsed); 1039 addBeginTime(elapsed, elapsed);
1037 } 1040 }
1038 1041
1039 } 1042 }
1040 1043
1041 #endif 1044 #endif
OLDNEW
« no previous file with comments | « LayoutTests/svg/animations/smil-element-target-crash-main-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698