Issue 9568005: Fix Error.prototype.toString to throw TypeError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9568005: Fix Error.prototype.toString to throw TypeError. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger

Modified:
8 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Error.prototype.toString to throw TypeError. R=rossberg@chromium.org BUG=v8:1980 TEST=mjsunit/function-call,mjsunit/regress/regress-1980 Committed: https://code.google.com/p/v8/source/detail?r=10922

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -21 lines)			Patch
M	src/messages.js	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/v8natives.js	View		12 chunks	+13 lines, -14 lines	0 comments	Download
M	test/mjsunit/function-call.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	test/mjsunit/regress/regress-1980.js	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

https://chromiumcodereview.appspot.com/9568005/diff/1/src/messages.js File src/messages.js (right): https://chromiumcodereview.appspot.com/9568005/diff/1/src/messages.js#newcode1194 src/messages.js:1194: throw MakeTypeError("called_on_non_object", ["Error.toString"]); Shouldn't that be Error.prototype.toString?

8 years, 9 months ago (2012-03-05 10:04:58 UTC) #2

Michael Starzinger

Added new patch set. https://chromiumcodereview.appspot.com/9568005/diff/1/src/messages.js File src/messages.js (right): https://chromiumcodereview.appspot.com/9568005/diff/1/src/messages.js#newcode1194 src/messages.js:1194: throw MakeTypeError("called_on_non_object", ["Error.toString"]); On 2012/03/05 ...

8 years, 9 months ago (2012-03-05 12:55:59 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 9568005: Fix Error.prototype.toString to throw TypeError. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Messages