Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 9567027: aura: Remove apps from NTP4 and disable NTP4 intro bubble. (Closed)

Created:
8 years, 9 months ago by xiyuan
Modified:
8 years, 9 months ago
Reviewers:
flackr, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

aura: Remove apps from NTP4 and disable NTP4 intro bubble. BUG=116318, 115952 TEST=Verify above issues. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124722

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -14 lines) Patch
M chrome/browser/resources/ntp4/page_list_view.js View 2 chunks +27 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 chunks +18 lines, -5 lines 1 comment Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
8 years, 9 months ago (2012-03-01 23:07:28 UTC) #1
Evan Stade
lgtm, except I think this will break the suggestions page (currently behind a flag), which ...
8 years, 9 months ago (2012-03-02 17:29:20 UTC) #2
Evan Stade
On 2012/03/02 17:29:20, Evan Stade wrote: > lgtm, except I think this will break the ...
8 years, 9 months ago (2012-03-02 17:30:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/9567027/1
8 years, 9 months ago (2012-03-02 17:40:33 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/webui/ntp/new_tab_ui.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/ntp/new_tab_ui.cc ...
8 years, 9 months ago (2012-03-02 19:23:39 UTC) #5
flackr
8 years, 9 months ago (2012-03-05 21:18:53 UTC) #6
https://chromiumcodereview.appspot.com/9567027/diff/4002/chrome/browser/ui/we...
File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right):

https://chromiumcodereview.appspot.com/9567027/diff/4002/chrome/browser/ui/we...
chrome/browser/ui/webui/ntp/new_tab_ui.cc:297: return false;
Aura compact mode does not have an apps page so we need to return true in this
case as well.

Powered by Google App Engine
This is Rietveld 408576698