Fix crash in inline cache: forgot to GC properly RawICData. Various cleanups.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 3661 matching lines @@
 class ICData : public Instance {
  public:
   RawFunction* function() const {
     return raw_ptr()->function_;
   }
 
   RawString* target_name() const {
     return raw_ptr()->target_name_;
   }
 
-  RawArray* ic_data() const {
-    return raw_ptr()->ic_data_;
-  }
-
   intptr_t num_args_tested() const {
     return raw_ptr()->num_args_tested_;
   }
 
   intptr_t id() const {
     return raw_ptr()->id_;
   }
 
   intptr_t NumberOfChecks() const;
 
@@ skipping 23 matching lines @@
                   GrowableArray<const Class*>* classes,
                   Function* target) const;
   void GetOneClassCheckAt(int index, Class* cls, Function* target) const;
 
   static RawICData* New(const Function& caller_function,
                         const String& target_name,
                         intptr_t id,
                         intptr_t num_args_tested);
 
  private:
+  RawArray* ic_data() const {
+    return raw_ptr()->ic_data_;
+  }
+
   void set_function(const Function& value) const;
   void set_target_name(const String& value) const;
   void set_id(intptr_t value) const;
   void set_num_args_tested(intptr_t value) const;
   void set_ic_data(const Array& value) const;
 
   intptr_t TestEntryLength() const;
 
   HEAP_OBJECT_IMPLEMENTATION(ICData, Instance);
   friend class Class;
@@ skipping 67 matching lines @@
 }
 
 
 void Context::SetAt(intptr_t index, const Instance& value) const {
   StorePointer(InstanceAddr(index), value.raw());
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_