Fix crash in inline cache: forgot to GC properly RawICData. Various cleanups.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 8478 matching lines @@
   GrowableArray<const Class*> classes;
   GetCheckAt(index, &classes, target);
   *cls = classes[0]->raw();
 }
 
 
 RawICData* ICData::New(const Function& function,
                        const String& target_name,
                        intptr_t id,
                        intptr_t num_args_tested) {
+  ASSERT(num_args_tested > 0);
   const Class& cls = Class::Handle(Object::icdata_class());
   ASSERT(!cls.IsNull());
   ICData& result = ICData::Handle();
   {
     // IC data objects ar long living objects, allocate them in old generation.
     RawObject* raw =
         Object::Allocate(cls, ICData::InstanceSize(), Heap::kOld);
     NoGCScope no_gc;
     result ^= raw;
   }
   result.set_function(function);
   result.set_target_name(target_name);
   result.set_id(id);
   result.set_num_args_tested(num_args_tested);
   // Number of array elements in one test entry (num_args_tested + 1)
-  intptr_t len = num_args_tested + 1;
+  intptr_t len = result.TestEntryLength();
   // IC data array must be null terminated (sentinel entry).
   Array& ic_data = Array::Handle(Array::New(len, Heap::kOld));
   result.set_ic_data(ic_data);
   return result.raw();
 }
 
 }  // namespace dart