Fix crash in inline cache: forgot to GC properly RawICData. Various cleanups.

runtime/vm/code_patcher_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/code_patcher.h"
 #include "vm/cpu.h"
@@ skipping 116 matching lines @@
  public:
   explicit InstanceCall(uword return_address)
       : DartCallPattern(return_address) {}
 
   RawICData* ic_data() const {
     ICData& ic_data = ICData::Handle();
     ic_data ^= reinterpret_cast<RawObject*>(immediate_one());
     return ic_data.raw();
   }
 
-  void SetIcData(const ICData& value) {
-    set_immediate_one(reinterpret_cast<int32_t>(value.raw()));
-  }
-
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(InstanceCall);
 };
 
 
 void CodePatcher::GetStaticCallAt(uword return_address,
                                   Function* function,
                                   uword* target) {
   ASSERT(function != NULL);
   ASSERT(target != NULL);
@@ skipping 108 matching lines @@
 }
 
 
 intptr_t CodePatcher::InstanceCallSizeInBytes() {
   return DartCallPattern::kNumInstructions * DartCallPattern::kInstructionSize;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32