Fix crash in inline cache: forgot to GC properly RawICData. Various cleanups.

runtime/vm/code_generator.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
@@ skipping 65 matching lines @@
     int num_arguments,
     const Array& optional_arguments_names) {
   const intptr_t num_named_args =
       optional_arguments_names.IsNull() ? 0 : optional_arguments_names.Length();
   const intptr_t num_pos_args = num_arguments - num_named_args;
 
   // Build the argument descriptor array, which consists of the total number of
   // arguments, the number of positional arguments, alphabetically sorted
   // pairs of name/position, and a terminating null.
   const int descriptor_len = 3 + (2 * num_named_args);
-  Array& descriptor = Array::ZoneHandle(Array::New(descriptor_len));
+  Array& descriptor = Array::ZoneHandle(Array::New(descriptor_len, Heap::kOld));
 
   // Set total number of passed arguments.
   descriptor.SetAt(0, Smi::Handle(Smi::New(num_arguments)));
   // Set number of positional arguments.
   descriptor.SetAt(1, Smi::Handle(Smi::New(num_pos_args)));
   // Set alphabetically sorted pairs of name/position for named arguments.
   String& name = String::Handle();
   Smi& pos = Smi::Handle();
   for (int i = 0; i < num_named_args; i++) {
     name ^= optional_arguments_names.At(i);
@@ skipping 1091 matching lines @@
       }
     }
   }
   // The cache is null terminated, therefore the loop above should never
   // terminate by itself.
   UNREACHABLE();
   return Code::null();
 }
 
 }  // namespace dart