Making the me2me host compiling and running on Windows. This includes making it a window applicatio…

remoting/host/simple_host_process.cc

Index: remoting/host/simple_host_process.cc
diff --git a/remoting/host/simple_host_process.cc b/remoting/host/simple_host_process.cc
index 4199d9fe1e83c77ed2bbea96fd1134e4c3b41d3c..4af95c028c9c3150e6332a11ab2d18e63210b838 100644
--- a/remoting/host/simple_host_process.cc
+++ b/remoting/host/simple_host_process.cc
@@ -21,8 +21,8 @@
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
-#include "base/environment.h"
 #include "base/file_path.h"
+#include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
@@ -69,9 +69,6 @@ namespace {
 const FilePath::CharType kDefaultConfigPath[] =
     FILE_PATH_LITERAL(".ChromotingConfig.json");
 
-const char kHomeDrive[] = "HOMEDRIVE";
-const char kHomePath[] = "HOMEPATH";
-
 const char kFakeSwitchName[] = "fake";
 const char kIT2MeSwitchName[] = "it2me";
 const char kConfigSwitchName[] = "config";
@@ -191,21 +188,15 @@ class SimpleHost {
     if (!config_path_.empty())
       return config_path_;
 
-    scoped_ptr<base::Environment> env(base::Environment::Create());
+    FilePath config_path;
 
 #if defined(OS_WIN)
-    std::string home_drive;
-    env->GetVar(kHomeDrive, &home_drive);
-    std::string home_path;
-    env->GetVar(kHomePath, &home_path);
-    return FilePath(UTF8ToWide(home_drive))
-        .Append(UTF8ToWide(home_path))
-        .Append(kDefaultConfigPath);
+    PathService::Get(base::DIR_PROFILE, &config_path);

[Wez, 2012/03/01 18:03:06]

This change moves the config from the home directory to the profile, so the CL
description should mention that.

[Jamie, 2012/03/01 18:22:32]

Better still, unless that change is required for this CL to work, split it into
a separate one.

[alexeypa (please no reviews), 2012/03/01 20:33:58]

This change does not change the location. There is no GetHomeDir()
implementation for Windows (for a reason). The homegrown implementation we had
was using the user profile folder as the home dir.

Actually this is something that we need to address later. Windows guidelines do
not recommend putting files to the profile folder. So we will need to move the
files to %LOCALAPPDATA% to make it more Windowsy.

[Wez, 2012/03/01 21:11:36]

The home-grown code was using HOMEDRIVE and HOMEPATH, rather than USERPROFILE.
PathService::Get(DIR_LOCAL_APP_DATA, ...) should achieve that.

[alexeypa (please no reviews), 2012/03/01 22:32:41]

Yes, I saw that. They can only be different if you change them after login, if
I'm not mistaken. Which is the same thing as changing HOME on Linux. It will
break things.
Yes. We'll need to come up with a better name than ".config" anyway. So I'll
better remove this file from this CL for now.

PS. You guys are so picky. :-)

[Wez, 2012/03/01 22:46:30]

Nope.  The home directory and profile directory can differ.  :)
:D

 #else
-    std::string home_path;
-    env->GetVar(base::env_vars::kHome, &home_path);
-    return FilePath(home_path).Append(kDefaultConfigPath);
+    config_path = file_util::GetHomeDir();
 #endif
+
+    return config_path.Append(kDefaultConfigPath);
   }
 
   void StartHost() {