Prevented default backspace handler in File Browser Gallery

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 /**
@@ skipping 2498 matching lines @@
     var dirPath = this.directoryModel_.currentEntry.fullPath;
 
     // Push a temporary state which will be replaced every time an individual
     // item is selected in the Gallery.
     this.updateLocation_(false /*push*/, dirPath);
 
     galleryFrame.onload = function() {
       self.document_.title = str('GALLERY');
       galleryFrame.contentWindow.ImageUtil.metrics = metrics;
       galleryFrame.contentWindow.FileType = FileType;
+      galleryFrame.contentWindow.util = util;
 
       galleryFrame.contentWindow.Gallery.open(
           self.directoryModel_.currentEntry,
           urls,
           selectedUrl,
           function(name) {
             self.updateLocation_(true /*replace*/, dirPath + '/' + name);
           },
           function () { history.back(1) },
           self.metadataProvider_,
@@ skipping 823 matching lines @@
 
   FileManager.prototype.onRenameInputKeyDown_ = function(event) {
     if (!this.isRenamingInProgress())
       return;
 
     // Do not move selection or lead item in list during rename.
     if (event.keyIdentifier == 'Up' || event.keyIdentifier == 'Down') {
       event.stopPropagation();
     }
 
-    if (event.ctrlKey || event.shiftKey || event.altKey || event.metaKey)
-      return;
-
-    switch (event.keyCode) {
-      case 27:  // Escape
+    switch (util.getKeyModifiers(event) + event.keyCode) {
+      case '27':  // Escape
         this.cancelRename_();
         event.preventDefault();
         break;
 
-      case 13:  // Enter
+      case '13':  // Enter
         this.commitRename_();
         event.preventDefault();
         break;
     }
   };
 
   FileManager.prototype.onRenameInputBlur_ = function(event) {
     if (this.isRenamingInProgress() && !this.renameInput_.validation_)
       this.cancelRename_();
   };
@@ skipping 51 matching lines @@
     var parent = this.renameInput_.parentNode;
     if (parent) {
       parent.removeAttribute('renaming');
       parent.removeChild(this.renameInput_);
     }
     this.refocus();
   };
 
   FileManager.prototype.onFilenameInputKeyUp_ = function(event) {
     var enabled = this.updateOkButton_();
-    if (event.ctrlKey || event.shiftKey || event.altKey || event.metaKey)
+    if (util.getKeyModifiers(event))
       return;
     if (enabled && event.keyCode == 13 /* Enter */)

[SeRya, 2012/03/02 11:00:31]

Let's unity approach. Put [util.getKeyModifiers(event) + event.keyCode == 13}
and remove if (..) return;

[Vladislav Kaznacheev, 2012/03/02 11:05:33]

Done.

       this.onOk_();
   };
 
   FileManager.prototype.onFilenameInputFocus_ = function(event) {
     var input = this.filenameInput_;
 
     // On focus we want to select everything but the extension, but
     // Chrome will select-all after the focus event completes.  We
     // schedule a timeout to alter the focus after that happens.
     setTimeout(function() {
@@ skipping 100 matching lines @@
 
   /**
    * KeyDown event handler for the document.
    */
   FileManager.prototype.onKeyDown_ = function(event) {
     if (event.srcElement === this.renameInput_) {
       // Ignore keydown handler in the rename input box.
       return;
     }
 
-    if (event.ctrlKey && !event.shiftKey && !event.altKey && !event.metaKey) {
-      switch (event.keyCode) {
-        case 190:  // Ctrl-. => Toggle filter files.
-          var dm = this.directoryModel_;
-          dm.filterHidden = !dm.filterHidden;
+    switch (util.getKeyModifiers(event) + event.keyCode) {
+      case 'Ctrl-190':  // Ctrl-. => Toggle filter files.
+        var dm = this.directoryModel_;
+        dm.filterHidden = !dm.filterHidden;
+        event.preventDefault();
+        return;
+
+      case '27':  // Escape => Cancel dialog.
+        if (this.copyManager_.getStatus().totalFiles != 0) {
+          // If there is a copy in progress, ESC will cancel it.
           event.preventDefault();
+          this.copyManager_.requestCancel();
           return;
-      }
-    }
+        }
 
-    if (!event.ctrlKey && !event.shiftKey && !event.altKey && !event.metaKey) {
-      switch (event.keyCode) {
-        case 27:  // Escape => Cancel dialog.
-          if (this.copyManager_.getStatus().totalFiles != 0) {
-            // If there is a copy in progress, ESC will cancel it.
-            event.preventDefault();
-            this.copyManager_.requestCancel();
-            return;
-          }
+        if (this.butterTimer_) {
+          // Allow the user to manually dismiss timed butter messages.
+          event.preventDefault();
+          this.hideButter();
+          return;
+        }
 
-          if (this.butterTimer_) {
-            // Allow the user to manually dismiss timed butter messages.
-            event.preventDefault();
-            this.hideButter();
-            return;
-          }
-
-          if (this.dialogType_ != FileManager.DialogType.FULL_PAGE) {
-            // If there is nothing else for ESC to do, then cancel the dialog.
-            event.preventDefault();
-            this.onCancel_();
-          }
-          break;
-      }
+        if (this.dialogType_ != FileManager.DialogType.FULL_PAGE) {
+          // If there is nothing else for ESC to do, then cancel the dialog.
+          event.preventDefault();
+          this.onCancel_();
+        }
+        break;
     }
   };
 
   /**
    * KeyDown event handler for the div.list-container element.
    */
   FileManager.prototype.onListKeyDown_ = function(event) {
     if (event.srcElement.tagName == 'INPUT') {
       // Ignore keydown handler in the rename input box.
       return;
     }
 
     var self = this;
     function handleCommand(name) {
       self.updateCommands_();
       if (self.commands_[name].disabled)
         return;
       event.preventDefault();
       event.stopPropagation();
       self.commands_[name].execute();
     }
 
-    if (event.ctrlKey && !event.shiftKey && !event.altKey && !event.metaKey) {
-      switch (event.keyCode) {
-        case 32:  // Ctrl-Space => New Folder.
-          handleCommand('newfolder');
-          break;
+    switch (util.getKeyModifiers(event) + event.keyCode) {
+      case 'Ctrl-32':  // Ctrl-Space => New Folder.
+        handleCommand('newfolder');
+        break;
 
-        case 88:  // Ctrl-X => Cut.
-          handleCommand('cut');
-          break;
+      case 'Ctrl-88':  // Ctrl-X => Cut.
+        handleCommand('cut');
+        break;
 
-        case 67:  // Ctrl-C => Copy.
-          handleCommand('copy');
-          break;
+      case 'Ctrl-67':  // Ctrl-C => Copy.
+        handleCommand('copy');
+        break;
 
-        case 86:  // Ctrl-V => Paste.
-          handleCommand('paste');
-          break;
+      case 'Ctrl-86':  // Ctrl-V => Paste.
+        handleCommand('paste');
+        break;
 
-        case 69:  // Ctrl-E => Rename.
-          handleCommand('rename');
-          break;
-      }
-    }
+      case 'Ctrl-69':  // Ctrl-E => Rename.
+        handleCommand('rename');
+        break;
 
-    if (event.ctrlKey || event.shiftKey || event.altKey || event.metaKey)
-      return;
-
-    switch (event.keyCode) {
-      case 8:  // Backspace => Up one directory.
+      case '8':  // Backspace => Up one directory.
         event.preventDefault();
         var path = this.getCurrentDirectory();
         if (path && !DirectoryModel.isRootPath(path)) {
           var path = path.replace(/\/[^\/]+$/, '');
           this.directoryModel_.changeDirectory(path);
         }
         break;
 
-      case 13:  // Enter => Change directory or perform default action.
+      case '13':  // Enter => Change directory or perform default action.
         if (this.selection.totalCount == 1 &&
             this.selection.entries[0].isDirectory &&
             this.dialogType_ != FileManager.SELECT_FOLDER) {
           event.preventDefault();
           this.onDirectoryAction(this.selection.entries[0]);
         } else if (this.dispatchSelectionAction_()) {
           event.preventDefault();
         }
         break;
 
-      case 46:  // Delete.
+      case '46':  // Delete.
         handleCommand('delete');
         break;
     }
   };
 
   /**
    * KeyPress event handler for the div.list-container element.
    */
   FileManager.prototype.onListKeyPress_ = function(event) {
     if (event.srcElement.tagName == 'INPUT') {
@@ skipping 251 matching lines @@
           });
       }, onError);
 
       function onError(err) {
         console.log('Error while checking free space: ' + err);
         setTimeout(doCheck, 1000 * 60);
       }
     }
   }
 })();