Prevented default backspace handler in File Browser Gallery

Prevented default backspace handler in File Browser Gallery


BUG=chromium-os:22846
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124633

[Vladislav Kaznacheev, 2012-03-01 09:18:40]

Please review.

[SeRya, 2012-03-01 11:04:08]

https://chromiumcodereview.appspot.com/9567003/diff/1/chrome/browser/resource...
File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right):

https://chromiumcodereview.appspot.com/9567003/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:575: if
(event.keyIdentifier == 'U+0008') {  // Backspace.
We should be specific about modification. Otherwise we surprisingly suppress
other keyboard shortcuts including global ones. Have a look at
FileManager.prototype.onKeyDown_.

[SeRya, 2012-03-01 11:07:55]

On 2012/03/01 11:04:08, SeRya wrote:
>
https://chromiumcodereview.appspot.com/9567003/diff/1/chrome/browser/resource...
> File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right):
> 
>
https://chromiumcodereview.appspot.com/9567003/diff/1/chrome/browser/resource...
> chrome/browser/resources/file_manager/js/image_editor/gallery.js:575: if
> (event.keyIdentifier == 'U+0008') {  // Backspace.
> We should be specific about modification. Otherwise we surprisingly suppress
> other keyboard shortcuts including global ones. Have a look at
> FileManager.prototype.onKeyDown_.

I mean keyboard modificators (like shift or control) instead 'modification'.

[Vladislav Kaznacheev, 2012-03-01 12:45:11]

PTAL

[Vladislav Kaznacheev, 2012-03-02 10:15:20]

Dmitry, can you take a look please?

Thanks,

  Vlad

[dgozman, 2012-03-02 10:54:36]

LGTM

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/util.js (right):

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
chrome/browser/resources/file_manager/js/util.js:480: * Returns a string
'[Ctrl-][Shift-][Alt-][Meta-]' depending on the event
Typically, alt is before shift, e.g. Alt+Shift+X.

[SeRya, 2012-03-02 11:00:31]

lgtm

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_manager.js:3443: if (enabled &&
event.keyCode == 13 /* Enter */)
Let's unity approach. Put [util.getKeyModifiers(event) + event.keyCode == 13}
and remove if (..) return;

[Vladislav Kaznacheev, 2012-03-02 11:05:33]

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_manager.js:3443: if (enabled &&
event.keyCode == 13 /* Enter */)
On 2012/03/02 11:00:31, SeRya wrote:
> Let's unity approach. Put [util.getKeyModifiers(event) + event.keyCode == 13}
> and remove if (..) return;

Done.

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/util.js (right):

https://chromiumcodereview.appspot.com/9567003/diff/5001/chrome/browser/resou...
chrome/browser/resources/file_manager/js/util.js:480: * Returns a string
'[Ctrl-][Shift-][Alt-][Meta-]' depending on the event
Done.
On 2012/03/02 10:54:36, dgozman wrote:
> Typically, alt is before shift, e.g. Alt+Shift+X.

[commit-bot: I haz the power, 2012-03-02 11:06:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9567003/6002