Issue 9566028: Update PRESUBMIT.py to be less likely to hit the android bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9566028: Update PRESUBMIT.py to be less likely to hit the android bot. (Closed)

Created:
8 years, 9 months ago by John Grabowski

Modified:
8 years, 9 months ago

Reviewers:
Jeff Bailey (chromium), M-A Ruel

CC:
chromium-reviews, Yaron

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update PRESUBMIT.py to be less likely to hit the android bot. BUG=None TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124485

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	PRESUBMIT.py	View		1 chunk	+17 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://chromiumcodereview.appspot.com/9566028/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://chromiumcodereview.appspot.com/9566028/diff/1/PRESUBMIT.py#newcode318 PRESUBMIT.py:318: android_re_list = ('^base/', '^ipc/', '^net/', '^sql/', '^jingle/', Can ...

8 years, 9 months ago (2012-03-01 21:21:40 UTC) #2

John Grabowski

8 years, 9 months ago (2012-03-02 01:25:21 UTC) #3

On 2012/03/01 21:21:40, Marc-Antoine Ruel wrote:
> lgtm
> 
> http://chromiumcodereview.appspot.com/9566028/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> http://chromiumcodereview.appspot.com/9566028/diff/1/PRESUBMIT.py#newcode318
> PRESUBMIT.py:318: android_re_list = ('^base/', '^ipc/', '^net/', '^sql/',
> '^jingle/',
> Can you put them one per line in sorted order?
> 
> http://chromiumcodereview.appspot.com/9566028/diff/1/PRESUBMIT.py#newcode324
> PRESUBMIT.py:324: for non_android_re in (aura_re, win_re):
> if any(
>     all(re.search(r, f) for f in affected_files)
>     for r in (aura_re, win_re)):
> 
> but I guess this becomes unreadable so ignore that.

For the record, I did place them in order, but didn't upload to rietveld.

Expand Messages | Collapse Messages