Issue 9566020: Revert 124071 - Gestures are now possible using touch events with any ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9566020: Revert 124071 - Gestures are now possible using touch events with any ids (Closed)

Created:
8 years, 9 months ago by Rick Byers

Modified:
8 years, 9 months ago

Reviewers:
tdresser

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 124071 - Gestures are now possible using touch events with any ids Reverting because this CL caused any tap in a tab contents (on device) to trigger a browser crash. See issue 116314 for details. -- Each gesture point stores a "point_id," which is used for state transitions in the GestureRecognizer. The point_ids are maintained such that the set of point_ids is always contiguous, from 0 to the number of current touches. A lower point_id indicates that a touch occurred first. BUG=113144 TEST=GestureRecognizerTest.* TBR=tdresser@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124451

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -207 lines)			Patch
M	ash/wm/root_window_event_filter_unittest.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	ui/aura/gestures/gesture_point.h	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	ui/aura/gestures/gesture_point.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View	58 chunks	+61 lines, -118 lines	0 comments	Download
M	ui/aura/gestures/gesture_sequence.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	ui/aura/gestures/gesture_sequence.cc	View	13 chunks	+47 lines, -62 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/03/01 19:34:44, Rick Byers wrote:

LGTM

Expand Messages | Collapse Messages