Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 9566014: Attempt 2: Allows tab dragging when maximized on aura. To fix it I made it so (Closed)

Created:
8 years, 9 months ago by sky
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Attempt 2: Allows tab dragging when maximized on aura. To fix it I made it so that you can drag a maximized window when tab dragging and no constraints are imposed on the window. Only when the mouse is released do we do anything. This only handles the multiple tab case, if you've selected all the tabs in a maximized window we won't detach. BUG=116074 TEST=none R=ben@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124440

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -28 lines) Patch
M ash/wm/property_util.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ash/wm/property_util.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/window_resizer.cc View 2 chunks +1 line, -9 lines 0 comments Download
M ash/wm/window_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 3 chunks +8 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 4 chunks +29 lines, -8 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 3 chunks +7 lines, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.cc View 4 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
My first patch got reverted because of some weird compiler error on win_aura. I don't ...
8 years, 9 months ago (2012-03-01 18:51:07 UTC) #1
Ben Goodger (Google)
8 years, 9 months ago (2012-03-01 18:57:54 UTC) #2
LGTM

On Thu, Mar 1, 2012 at 10:51 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> My first patch got reverted because of some weird compiler error on
> win_aura. I
> don't think it's related. I did realize there is a bug in the destruction
> order
> and fixed that in patchset 2.
>
> I'm TBR since this is a simple change.
>
> Description:
> Attempt 2: Allows tab dragging when maximized on aura. To fix it I made it
> so
> that you can drag a maximized window when tab dragging and no
> constraints are imposed on the window. Only when the mouse is released
> do we do anything. This only handles the multiple tab case, if you've
> selected all the tabs in a maximized window we won't detach.
>
> BUG=116074
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/9566014/<http://codereview.chromium.org/9566...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/wm/property_util.h
>  M ash/wm/property_util.cc
>  M ash/wm/toplevel_window_event_**filter.cc
>  M ash/wm/window_resizer.cc
>  M ash/wm/window_util.h
>  M ash/wm/window_util.cc
>  M ash/wm/workspace/workspace_**event_filter.cc
>  M ash/wm/workspace/workspace_**layout_manager.h
>  M ash/wm/workspace/workspace_**layout_manager.cc
>  M ash/wm/workspace/workspace_**manager.h
>  M ash/wm/workspace/workspace_**manager.cc
>  M ash/wm/workspace/workspace_**window_resizer.h
>  M ash/wm/workspace/workspace_**window_resizer.cc
>  M ash/wm/workspace_controller.cc
>  M chrome/browser/ui/views/tabs/**tab_drag_controller2.h
>  M chrome/browser/ui/views/tabs/**tab_drag_controller2.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698