Issue 9565046: NaCl: Cleanup: Get some definitions from header file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9565046: NaCl: Cleanup: Get some definitions from header file (Closed)

Created:
8 years, 9 months ago by Mark Seaborn

Modified:
8 years, 9 months ago

Reviewers:
sehr (please use chromium), Nick Bray (chromium)

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Cleanup: Get some definitions from header file Remove the duplicated prototypes and typedefs now that we have a NaCl header file to get them from that can be #included from Chromium without conflicts. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2628 TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124685

Patch Set 1 #

Patch Set 2 : Copyright #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -15 lines)			Patch
	M	chrome/nacl/nacl_listener.cc	View	1	4 chunks	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nick Bray (chromium)

LGTM, but I am doing something similar. Also, you'll need a full commiter to approve ...

8 years, 9 months ago (2012-03-02 02:29:52 UTC) #2

lgtm

Expand Messages | Collapse Messages