Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Side by Side Diff: Source/WebCore/loader/FrameLoader.cpp

Issue 9565031: Merge 109369 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/frames/url-selected-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 4 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) Research In Motion Limited 2009. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2009. All rights reserved.
7 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com> 7 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>
8 * Copyright (C) 2011 Google Inc. All rights reserved. 8 * Copyright (C) 2011 Google Inc. All rights reserved.
9 * 9 *
10 * Redistribution and use in source and binary forms, with or without 10 * Redistribution and use in source and binary forms, with or without
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 history()->setDefersLoading(defers); 243 history()->setDefersLoading(defers);
244 244
245 if (!defers) { 245 if (!defers) {
246 m_frame->navigationScheduler()->startTimer(); 246 m_frame->navigationScheduler()->startTimer();
247 startCheckCompleteTimer(); 247 startCheckCompleteTimer();
248 } 248 }
249 } 249 }
250 250
251 void FrameLoader::changeLocation(SecurityOrigin* securityOrigin, const KURL& url , const String& referrer, bool lockHistory, bool lockBackForwardList, bool refre sh) 251 void FrameLoader::changeLocation(SecurityOrigin* securityOrigin, const KURL& url , const String& referrer, bool lockHistory, bool lockBackForwardList, bool refre sh)
252 { 252 {
253 RefPtr<Frame> protect(m_frame);
254 urlSelected(FrameLoadRequest(securityOrigin, ResourceRequest(url, referrer, refresh ? ReloadIgnoringCacheData : UseProtocolCachePolicy), "_self"), 253 urlSelected(FrameLoadRequest(securityOrigin, ResourceRequest(url, referrer, refresh ? ReloadIgnoringCacheData : UseProtocolCachePolicy), "_self"),
255 0, lockHistory, lockBackForwardList, MaybeSendReferrer, ReplaceDocumentI fJavaScriptURL); 254 0, lockHistory, lockBackForwardList, MaybeSendReferrer, ReplaceDocumentI fJavaScriptURL);
256 } 255 }
257 256
258 void FrameLoader::urlSelected(const KURL& url, const String& passedTarget, PassR efPtr<Event> triggeringEvent, bool lockHistory, bool lockBackForwardList, Should SendReferrer shouldSendReferrer) 257 void FrameLoader::urlSelected(const KURL& url, const String& passedTarget, PassR efPtr<Event> triggeringEvent, bool lockHistory, bool lockBackForwardList, Should SendReferrer shouldSendReferrer)
259 { 258 {
260 urlSelected(FrameLoadRequest(m_frame->document()->securityOrigin(), Resource Request(url), passedTarget), 259 urlSelected(FrameLoadRequest(m_frame->document()->securityOrigin(), Resource Request(url), passedTarget),
261 triggeringEvent, lockHistory, lockBackForwardList, shouldSendReferrer, D oNotReplaceDocumentIfJavaScriptURL); 260 triggeringEvent, lockHistory, lockBackForwardList, shouldSendReferrer, D oNotReplaceDocumentIfJavaScriptURL);
262 } 261 }
263 262
264 // The shouldReplaceDocumentIfJavaScriptURL parameter will go away when the FIXM E to eliminate the 263 // The shouldReplaceDocumentIfJavaScriptURL parameter will go away when the FIXM E to eliminate the
265 // corresponding parameter from ScriptController::executeIfJavaScriptURL() is ad dressed. 264 // corresponding parameter from ScriptController::executeIfJavaScriptURL() is ad dressed.
266 void FrameLoader::urlSelected(const FrameLoadRequest& passedRequest, PassRefPtr< Event> triggeringEvent, bool lockHistory, bool lockBackForwardList, ShouldSendRe ferrer shouldSendReferrer, ShouldReplaceDocumentIfJavaScriptURL shouldReplaceDoc umentIfJavaScriptURL) 265 void FrameLoader::urlSelected(const FrameLoadRequest& passedRequest, PassRefPtr< Event> triggeringEvent, bool lockHistory, bool lockBackForwardList, ShouldSendRe ferrer shouldSendReferrer, ShouldReplaceDocumentIfJavaScriptURL shouldReplaceDoc umentIfJavaScriptURL)
267 { 266 {
268 ASSERT(!m_suppressOpenerInNewFrame); 267 ASSERT(!m_suppressOpenerInNewFrame);
269 268
269 RefPtr<Frame> protect(m_frame);
270 FrameLoadRequest frameRequest(passedRequest); 270 FrameLoadRequest frameRequest(passedRequest);
271 271
272 if (m_frame->script()->executeIfJavaScriptURL(frameRequest.resourceRequest() .url(), shouldReplaceDocumentIfJavaScriptURL)) 272 if (m_frame->script()->executeIfJavaScriptURL(frameRequest.resourceRequest() .url(), shouldReplaceDocumentIfJavaScriptURL))
273 return; 273 return;
274 274
275 if (frameRequest.frameName().isEmpty()) 275 if (frameRequest.frameName().isEmpty())
276 frameRequest.setFrameName(m_frame->document()->baseTarget()); 276 frameRequest.setFrameName(m_frame->document()->baseTarget());
277 277
278 if (shouldSendReferrer == NeverSendReferrer) 278 if (shouldSendReferrer == NeverSendReferrer)
279 m_suppressOpenerInNewFrame = true; 279 m_suppressOpenerInNewFrame = true;
(...skipping 3090 matching lines...) Expand 10 before | Expand all | Expand 10 after
3370 windowRect.setHeight(features.height + (windowRect.height() - pageSize.h eight())); 3370 windowRect.setHeight(features.height + (windowRect.height() - pageSize.h eight()));
3371 page->chrome()->setWindowRect(windowRect); 3371 page->chrome()->setWindowRect(windowRect);
3372 3372
3373 page->chrome()->show(); 3373 page->chrome()->show();
3374 3374
3375 created = true; 3375 created = true;
3376 return frame; 3376 return frame;
3377 } 3377 }
3378 3378
3379 } // namespace WebCore 3379 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/frames/url-selected-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698