Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 9565021: ui/gfx: Drop unused args from PaintMenuBackgroundColor() and pass gfx::Size instead of gfx::Rect. (Closed)

Created:
8 years, 9 months ago by tfarina
Modified:
8 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

ui/gfx: Drop unused args from PaintMenuBackgroundColor() and pass gfx::Size instead of gfx::Rect. This is a follow up patch to address the comments from: http://codereview.chromium.org/9544001/diff/2007/ui/gfx/native_theme_chromeos.cc#newcode662 R=pkasting@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -48 lines) Patch
M ui/gfx/native_theme_aura.h View 1 chunk +11 lines, -21 lines 0 comments Download
M ui/gfx/native_theme_aura.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/gfx/native_theme_base.h View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/gfx/native_theme_base.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/gfx/native_theme_chromeos.h View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/gfx/native_theme_chromeos.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 9 months ago (2012-03-01 20:13:26 UTC) #1
Peter Kasting
8 years, 9 months ago (2012-03-01 20:14:59 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698