Issue 9565008: Better fullscreen handling for Chrome OS Video Player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9565008: Better fullscreen handling for Chrome OS Video Player (Closed)

Created:
8 years, 9 months ago by Vladislav Kaznacheev

Modified:
8 years, 9 months ago

Reviewers:
asargent_no_longer_on_chrome, dgozman, USE_CHROMIUM_ACCT_INSTEAD, aa

CC:
chromium-reviews, nkostylev+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Better fullscreen handling for Chrome OS Video Player This is a revival of https://chromiumcodereview.appspot.com/9288062/ which was abandoned in favor of https://chromiumcodereview.appspot.com/9298009/. Turns out that webkitRequestFullscreen is not suitable for Chrome OS File Browser because it gives us a different kind of fullscreen mode than the one we get when pressing the dedicated Chromebook key (see the bug for details). BUG=chromium-os:26003 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124631

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -13 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View	2 chunks	+25 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/fileBrowserPrivate.json	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Hi, Please review this small patch. It adds two methods to chrome.fileBrowserPrivate API. Best regards, ...

8 years, 9 months ago (2012-03-01 12:58:46 UTC) #1

commit-bot: I haz the power

8 years, 9 months ago (2012-03-02 10:12:01 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/9565008/1

Expand Messages | Collapse Messages