Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 9565007: Fix a register assignment bug in typed array stores without SSE3 available. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Fixed assert for real Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1745 matching lines...) Expand 10 before | Expand all | Expand 10 after
1756 } else { 1756 } else {
1757 ASSERT(input_rep.IsTagged()); 1757 ASSERT(input_rep.IsTagged());
1758 // Register allocator doesn't (yet) support allocation of double 1758 // Register allocator doesn't (yet) support allocation of double
1759 // temps. Reserve d1 explicitly. 1759 // temps. Reserve d1 explicitly.
1760 LClampTToUint8* result = new(zone()) LClampTToUint8(reg, FixedTemp(d11)); 1760 LClampTToUint8* result = new(zone()) LClampTToUint8(reg, FixedTemp(d11));
1761 return AssignEnvironment(DefineAsRegister(result)); 1761 return AssignEnvironment(DefineAsRegister(result));
1762 } 1762 }
1763 } 1763 }
1764 1764
1765 1765
1766 LInstruction* LChunkBuilder::DoToInt32(HToInt32* instr) {
1767 HValue* value = instr->value();
1768 Representation input_rep = value->representation();
1769 LOperand* reg = UseRegister(value);
1770 if (input_rep.IsDouble()) {
1771 LOperand* temp1 = TempRegister();
1772 LOperand* temp2 = TempRegister();
1773 LDoubleToI* res = new(zone()) LDoubleToI(reg, temp1, temp2);
1774 return AssignEnvironment(DefineAsRegister(res));
1775 } else if (input_rep.IsInteger32()) {
1776 // Canonicalization should already have removed the hydrogen instruction in
1777 // this case, since it is a noop.
1778 UNREACHABLE();
1779 return NULL;
1780 } else {
1781 ASSERT(input_rep.IsTagged());
1782 LOperand* temp1 = TempRegister();
1783 LOperand* temp2 = TempRegister();
1784 LOperand* temp3 = FixedTemp(d11);
1785 LTaggedToI* res = new(zone()) LTaggedToI(reg, temp1, temp2, temp3);
1786 return AssignEnvironment(DefineSameAsFirst(res));
1787 }
1788 }
1789
1790
1791 LInstruction* LChunkBuilder::DoReturn(HReturn* instr) { 1766 LInstruction* LChunkBuilder::DoReturn(HReturn* instr) {
1792 return new(zone()) LReturn(UseFixed(instr->value(), r0)); 1767 return new(zone()) LReturn(UseFixed(instr->value(), r0));
1793 } 1768 }
1794 1769
1795 1770
1796 LInstruction* LChunkBuilder::DoConstant(HConstant* instr) { 1771 LInstruction* LChunkBuilder::DoConstant(HConstant* instr) {
1797 Representation r = instr->representation(); 1772 Representation r = instr->representation();
1798 if (r.IsInteger32()) { 1773 if (r.IsInteger32()) {
1799 return DefineAsRegister(new(zone()) LConstantI); 1774 return DefineAsRegister(new(zone()) LConstantI);
1800 } else if (r.IsDouble()) { 1775 } else if (r.IsDouble()) {
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
2325 2300
2326 2301
2327 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2302 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2328 LOperand* object = UseRegister(instr->object()); 2303 LOperand* object = UseRegister(instr->object());
2329 LOperand* index = UseRegister(instr->index()); 2304 LOperand* index = UseRegister(instr->index());
2330 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2305 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2331 } 2306 }
2332 2307
2333 2308
2334 } } // namespace v8::internal 2309 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698