Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 9565004: Revert 124385 - Allows tab dragging when maximized on aura. To fix it I made it so (Closed)

Created:
8 years, 9 months ago by battre
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 124385 - Allows tab dragging when maximized on aura. To fix it I made it so that you can drag a maximized window when tab dragging and no constraints are imposed on the window. Only when the mouse is released do we do anything. This only handles the multiple tab case, if you've selected all the tabs in a maximized window we won't detach. BUG=116074 TEST=none R=ben@chromium.org Reverting to fix linker issues, see http://crbug.com/116074 for details. Review URL: http://codereview.chromium.org/9549009 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -129 lines) Patch
M ash/wm/property_util.h View 2 chunks +0 lines, -12 lines 0 comments Download
M ash/wm/property_util.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/window_resizer.cc View 2 chunks +9 lines, -1 line 0 comments Download
M ash/wm/window_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/window_util.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 3 chunks +1 line, -8 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 4 chunks +8 lines, -29 lines 0 comments Download
M ash/wm/workspace/workspace_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2.cc View 4 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
battre
8 years, 9 months ago (2012-03-01 08:42:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698