Issue 9565002: Fixing paste operation in File Browser

Issue 9565002: Fixing paste operation in File Browser (Closed)

Created:
8 years, 9 months ago by Vladislav Kaznacheev

Modified:
8 years, 9 months ago

Reviewers:
dgozman, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing paste operation in File Browser BUG=chromium-os:26878 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124401

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -8 lines)			Patch
	M	chrome/browser/resources/file_manager/css/file_manager.css	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		6 chunks	+13 lines, -8 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Hi, Please review. Paste stopped working on the ToT Linux build because event.clipboardData was null ...

8 years, 9 months ago (2012-03-01 07:04:50 UTC) #1

dgozman

LGTM https://chromiumcodereview.appspot.com/9565002/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9565002/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2870 chrome/browser/resources/file_manager/js/file_manager.js:2870: if (!event.clipboardData.getData('fs/isCut')) Do we need similar checks here?

8 years, 9 months ago (2012-03-01 08:28:40 UTC) #2

Vladislav Kaznacheev

https://chromiumcodereview.appspot.com/9565002/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9565002/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2870 chrome/browser/resources/file_manager/js/file_manager.js:2870: if (!event.clipboardData.getData('fs/isCut')) For some reason this is not happening. ...

8 years, 9 months ago (2012-03-01 08:33:01 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-01 08:33:14 UTC) #4

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages