Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9564025: Display correct error message when the client fails to establish P2P connection. (Closed)

Created:
8 years, 9 months ago by Sergey Ulanov
Modified:
8 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Display correct error message when the client fails to establish P2P connection. BUG=110844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124573

Patch Set 1 #

Total comments: 2

Patch Set 2 : - #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M remoting/webapp/_locales/en/messages.json View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/webapp/client_screen.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/remoting.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
8 years, 9 months ago (2012-03-01 21:52:39 UTC) #1
Jamie
lgtm, but see if you can come up with something a bit more descriptive for ...
8 years, 9 months ago (2012-03-01 22:43:06 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/9564025/diff/1/remoting/webapp/_locales/en/messages.json File remoting/webapp/_locales/en/messages.json (right): http://codereview.chromium.org/9564025/diff/1/remoting/webapp/_locales/en/messages.json#newcode115 remoting/webapp/_locales/en/messages.json:115: "message": "Unable to reach the host.", On 2012/03/01 22:43:06, ...
8 years, 9 months ago (2012-03-01 23:17:16 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 23:17:30 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698