Issue 9564023: Revert 124461 - Remove the singleton instance get/delete methods from RootWindow (yay)

Issue 9564023: Revert 124461 - Remove the singleton instance get/delete methods from RootWindow (yay) (Closed)

Created:
8 years, 9 months ago by Ben Goodger (Google)

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, dhollowa+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tfarina, ctguil+watch_chromium.org, yoshiki+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 124461 - Remove the singleton instance get/delete methods from RootWindow (yay) http://crbug.com/112131 TEST=none Review URL: https://chromiumcodereview.appspot.com/9535025 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124479

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -119 lines)			Patch
M	ash/shell.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/shell.cc	View	4 chunks	+8 lines, -13 lines	0 comments	Download
M	ash/shell/shell_main.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/test/ash_test_base.cc	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_extra_parts_aura.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility_event_router_views_unittest.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/test/base/browser_with_test_window_test.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/test/base/browser_with_test_window_test.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/base/chrome_render_view_host_test_harness.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/view_event_test_base.cc	View	5 chunks	+5 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	ui/aura/demo/demo_main.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/aura/root_window.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/aura/root_window.cc	View	2 chunks	+58 lines, -44 lines	0 comments	Download
M	ui/aura/root_window_host_linux.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/aura/root_window_host_linux.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	ui/aura/test/aura_test_base.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/aura/test/aura_test_base.cc	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	ui/views/test/views_test_base.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/test/views_test_base.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/views/widget/native_widget_aura_unittest.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages