Issue 9564012: Cache result of ScriptNameOrSourceURL function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9564012: Cache result of ScriptNameOrSourceURL function (Closed)

Created:
8 years, 9 months ago by yurys

Modified:
8 years, 9 months ago

Reviewers:
danno

CC:
v8-dev, pfeldman, eustas.com, loislo

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Cache result of ScriptNameOrSourceURL function. The function is quite slow on large(several MBs) scripts which causes significant slowdown when capturing stack trace for such scripts. Committed: https://code.google.com/p/v8/source/detail?r=10902

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	src/messages.js	View	1 2	3 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM with comments addressed. https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js File src/messages.js (right): https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js#newcode562 src/messages.js:562: sourceUrl = SubString(source, matchInfo[CAPTURE(2)], matchInfo[CAPTURE(3)]); ...

8 years, 9 months ago (2012-03-02 12:06:31 UTC) #2

yurys

8 years, 9 months ago (2012-03-02 12:22:20 UTC) #3

https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js
File src/messages.js (right):

https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js#newcode562
src/messages.js:562: sourceUrl = SubString(source, matchInfo[CAPTURE(2)],
matchInfo[CAPTURE(3)]);
On 2012/03/02 12:06:32, danno wrote:
> 80 col

Done.

https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js#newcode565
src/messages.js:565: this.cachedNameOrSourceURL = sourceUrl || this.name;
On 2012/03/02 12:06:32, danno wrote:
> I think it's a bit more readable if you name the variable nameOrSourceURL and
> initialize it to this.name. That obviates the need for the use of the ||
> operator in this way.

Done.

Expand Messages | Collapse Messages