Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 9562053: Removed calls to Entry.file() to read file sizes. We get this information from Entry.getMetadata() … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/file_manager.js
===================================================================
--- chrome/browser/resources/file_manager/js/file_manager.js (revision 124537)
+++ chrome/browser/resources/file_manager/js/file_manager.js (working copy)
@@ -305,12 +305,6 @@
invokeCallback(successCallback, !!opt_sync, entry);
return;
}
-
- batchAsyncCall(entry, 'file', function(file) {
- entry.cachedSize_ = file.size;
- if (successCallback)
- successCallback(entry);
- }, opt_errorCallback);
}
/**
@@ -334,8 +328,9 @@
}
if (entry.isFile) {
- batchAsyncCall(entry, 'file', function(file) {
- entry.cachedMtime_ = file.lastModifiedDate;
+ batchAsyncCall(entry, 'getMetadata', function(metadata) {
+ entry.cachedMtime_ = metadata.modificationTime;
+ entry.cachedSize_ = metadata.size;
if (successCallback)
successCallback(entry);
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698