chrome/browser/resources/options2/options_page.js - Issue 9562050: Fix NOT_FOUND_ERR when opening sync dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options2/options_page.js

Issue 9562050: Fix NOT_FOUND_ERR when opening sync dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options2/options_page.js

diff --git a/chrome/browser/resources/options2/options_page.js b/chrome/browser/resources/options2/options_page.js

index b317050b733aa465e9152565db70fd00898661bb..3487292db1800859cf838f22286f70f5e5f6562b 100644

--- a/chrome/browser/resources/options2/options_page.js

+++ b/chrome/browser/resources/options2/options_page.js

@@ -921,7 +921,7 @@ cr.define('options', function() {

if (this.isOverlay) {

var content = this.pageDiv.querySelector('.content-area');

- this.pageDiv.insertBefore(bannerDiv, content);

+ content.parentElement.insertBefore(bannerDiv, content);

} else {

bannerDiv.classList.add('main-page-banner');

var header = this.pageDiv.querySelector('header');

« no previous file with comments | « no previous file | no next file » | no next file with comments »