Issue 9562049: Move the core drag&drop code for Windows to content\browser to match Mac/GTK. I've had to add tempo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9562049: Move the core drag&drop code for Windows to content\browser to match Mac/GTK. I've had to add tempo… (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
dcheng

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move the core drag&drop code for Windows to content\browser to match Mac/GTK. I've had to add temporary exceptions to DEPS which I'll remove in followup changes. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124603

Patch Set 1 : #

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -642 lines)			Patch
M	chrome/browser/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
D	chrome/browser/tab_contents/web_drag_source_win.h	View		1 chunk	+0 lines, -70 lines	0 comments	Download
D	chrome/browser/tab_contents/web_drag_source_win.cc	View		1 chunk	+0 lines, -126 lines	0 comments	Download
D	chrome/browser/tab_contents/web_drag_utils_win.h	View		1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/browser/tab_contents/web_drag_utils_win.cc	View		1 chunk	+0 lines, -61 lines	0 comments	Download
D	chrome/browser/tab_contents/web_drop_target_win.h	View		1 chunk	+0 lines, -80 lines	0 comments	Download
D	chrome/browser/tab_contents/web_drop_target_win.cc	View		1 chunk	+0 lines, -214 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.h	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc	View	1	4 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/browser/tab_contents/web_drag_dest_win.h	View		3 chunks	+9 lines, -8 lines	0 comments	Download
A +	content/browser/tab_contents/web_drag_dest_win.cc	View		6 chunks	+19 lines, -24 lines	0 comments	Download
A +	content/browser/tab_contents/web_drag_source_win.h	View		3 chunks	+6 lines, -5 lines	0 comments	Download
A +	content/browser/tab_contents/web_drag_source_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	content/browser/tab_contents/web_drag_utils_win.h	View		2 chunks	+6 lines, -5 lines	0 comments	Download
A +	content/browser/tab_contents/web_drag_utils_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages