Added stack overflow checks at backward branches in order to allow interrupting endless loops. Bett…

runtime/vm/code_generator_x64.cc

Index: runtime/vm/code_generator_x64.cc
===================================================================
--- runtime/vm/code_generator_x64.cc	(revision 4847)
+++ runtime/vm/code_generator_x64.cc	(working copy)
@@ -1797,6 +1797,21 @@
 }
 
 
+void CodeGenerator::HandleBackwardBranch(
+    intptr_t loop_id, intptr_t token_index) {
+  // Use stack overflow check to eventually stop execution of loops.
+  // This is necessary only if a loop does not have calls.
+  __ movq(TMP, Immediate(Isolate::Current()->stack_limit_address()));
+  __ cmpq(RSP, Address(TMP, 0));
+  Label no_stack_overflow;
+  __ j(ABOVE, &no_stack_overflow);
+  GenerateCallRuntime(AstNode::kNoId,
+                      0,

[regis, 2012/03/02 01:49:17]

Why do you pass kNoId and 0 instead of loop_id and token_index, as in the ia32
version?
I noticed other occurrences in several locations and 'fixed' them in the x64
version in past cls. Should I not have?

[srdjan, 2012/03/02 17:40:00]

My mistake, you have done it right.
Fixed.

+                      kStackOverflowRuntimeEntry);
+  __ Bind(&no_stack_overflow);
+}
+
+
 void CodeGenerator::VisitWhileNode(WhileNode* node) {
   const Bool& bool_true = Bool::ZoneHandle(Bool::True());
   SourceLabel* label = node->label();
@@ -1808,6 +1823,7 @@
   __ cmpq(RAX, RDX);
   __ j(NOT_EQUAL, label->break_label());
   node->body()->Visit(this);
+  HandleBackwardBranch(node->id(), node->token_index());
   __ jmp(label->continue_label());
   __ Bind(label->break_label());
 }
@@ -1819,6 +1835,7 @@
   Label loop;
   __ Bind(&loop);
   node->body()->Visit(this);
+  HandleBackwardBranch(node->id(), node->token_index());
   __ Bind(label->continue_label());
   node->condition()->Visit(this);
   GenerateConditionTypeCheck(node->id(), node->condition()->token_index());
@@ -1845,6 +1862,7 @@
     __ j(NOT_EQUAL, label->break_label());
   }
   node->body()->Visit(this);
+  HandleBackwardBranch(node->id(), node->token_index());
   __ Bind(label->continue_label());
   node->increment()->Visit(this);
   __ jmp(&loop);