Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 9562037: Move TestURLRequestContextGetter to url_request_test_util.{h,cc} (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
CC:
chromium-reviews, GeorgeY, cbentzel+watch_chromium.org, dhollowa+watch_chromium.org, jam, ncarter (slow), joi+watch-content_chromium.org, darin-cc_chromium.org, dyu1, Raghu Simha, pam+watch_chromium.org, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

Move TestURLRequestContextGetter to url_request_test_util.{h,cc} Make everything use this instead of rolling their own. BUG=113723 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124758

Patch Set 1 #

Patch Set 2 : fix deps #

Patch Set 3 : Fix gyp #

Total comments: 2

Patch Set 4 : Change comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -227 lines) Patch
M chrome/browser/autofill/autofill_download_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/intents/cws_intents_registry_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client_unittest.cc View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/DEPS View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/invalidation_notifier_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/tools/sync_tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 3 chunks +1 line, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 2 chunks +7 lines, -19 lines 0 comments Download
D chrome/test/base/test_url_request_context_getter.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/test/base/test_url_request_context_getter.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/net/url_fetcher_impl_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket_unittest.cc View 1 2 3 4 chunks +26 lines, -28 lines 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 4 chunks +4 lines, -28 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_unittest.cc View 4 chunks +3 lines, -28 lines 0 comments Download
M net/net.gyp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_test_util.h View 3 chunks +26 lines, -0 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
akalin
+willchan for net +asargent for component updaters +darin for content +zea for everything else PTAL
8 years, 9 months ago (2012-03-01 23:26:33 UTC) #1
willchan no longer on Chromium
302 Found Server: willchan Location: mmenke Thanks Matt :)
8 years, 9 months ago (2012-03-01 23:35:54 UTC) #2
mmenke
On 2012/03/01 23:35:54, willchan wrote: > 302 Found > Server: willchan > Location: mmenke > ...
8 years, 9 months ago (2012-03-01 23:56:15 UTC) #3
asargent_no_longer_on_chrome
component_updater_service_unittest.cc LGTM
8 years, 9 months ago (2012-03-02 18:11:58 UTC) #4
Nicolas Zea
"everything else" - LGTM http://codereview.chromium.org/9562037/diff/6002/jingle/notifier/base/proxy_resolving_client_socket_unittest.cc File jingle/notifier/base/proxy_resolving_client_socket_unittest.cc (right): http://codereview.chromium.org/9562037/diff/6002/jingle/notifier/base/proxy_resolving_client_socket_unittest.cc#newcode26 jingle/notifier/base/proxy_resolving_client_socket_unittest.cc:26: virtual TestURLRequestContext* GetURLRequestContext() OVERRIDE { ...
8 years, 9 months ago (2012-03-02 19:12:26 UTC) #5
akalin
ping, Darin and Matt!
8 years, 9 months ago (2012-03-02 19:32:00 UTC) #6
mmenke
net LGTM.
8 years, 9 months ago (2012-03-02 19:37:25 UTC) #7
willchan no longer on Chromium
lgtm
8 years, 9 months ago (2012-03-02 22:22:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9562037/6002
8 years, 9 months ago (2012-03-02 22:22:44 UTC) #9
akalin
8 years, 9 months ago (2012-03-02 22:55:50 UTC) #10
committing

http://codereview.chromium.org/9562037/diff/6002/jingle/notifier/base/proxy_r...
File jingle/notifier/base/proxy_resolving_client_socket_unittest.cc (right):

http://codereview.chromium.org/9562037/diff/6002/jingle/notifier/base/proxy_r...
jingle/notifier/base/proxy_resolving_client_socket_unittest.cc:26: virtual
TestURLRequestContext* GetURLRequestContext() OVERRIDE {
On 2012/03/02 19:12:27, nzea wrote:
> Comment about what this accomplishes.

Done.

Powered by Google App Engine
This is Rietveld 408576698