Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 9562032: Use the new CreateSnapshotFile() in FileSystemURLRequest job (Closed)

Created:
8 years, 9 months ago by kinuko
Modified:
8 years, 9 months ago
Reviewers:
michaeln
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Use the new CreateSnapshotFile() in FileSystemURLRequest job BUG=115603 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124694

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M webkit/fileapi/file_system_url_request_job.h View 1 4 chunks +11 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
hadn't published this... ptl.
8 years, 9 months ago (2012-03-02 01:42:07 UTC) #1
michaeln
LGTM https://chromiumcodereview.appspot.com/9562032/diff/1/webkit/fileapi/file_system_url_request_job.h File webkit/fileapi/file_system_url_request_job.h (right): https://chromiumcodereview.appspot.com/9562032/diff/1/webkit/fileapi/file_system_url_request_job.h#newcode68 webkit/fileapi/file_system_url_request_job.h:68: deletable_file_Ref); might just say file_ref, definitely nix the ...
8 years, 9 months ago (2012-03-02 01:55:18 UTC) #2
kinuko
thx, http://codereview.chromium.org/9562032/diff/1/webkit/fileapi/file_system_url_request_job.h File webkit/fileapi/file_system_url_request_job.h (right): http://codereview.chromium.org/9562032/diff/1/webkit/fileapi/file_system_url_request_job.h#newcode68 webkit/fileapi/file_system_url_request_job.h:68: deletable_file_Ref); On 2012/03/02 01:55:18, michaeln wrote: > might ...
8 years, 9 months ago (2012-03-02 02:20:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/9562032/4003
8 years, 9 months ago (2012-03-02 02:43:01 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 03:29:11 UTC) #5
Try job failure for 9562032-4003 on win_rel for steps "update_scripts, update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698