GTK: Draw the correct omnibox state with new tab-to-traverse behavior.

GTK: Draw the correct omnibox state with new tab-to-traverse behavior.

This does everything but animate the trailing ">" icon from the right
side of the omnibox to the left when entering tab-to-search mode. The
TTS arrow indicator is now properly GTK themed, as well.

(Doing the animation is lower priority. It would require more
extensive refactoring that I don't have time for as I have code yellow work.)

BUG=116292
TEST=all new tab-to-search behavior matches views sans animation.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124552

[Peter Kasting, 2012-03-01 22:02:12]

LGTM.  Refactoring would really take longer than a day?

https://chromiumcodereview.appspot.com/9562029/diff/1/chrome/browser/ui/gtk/o...
File chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/9562029/diff/1/chrome/browser/ui/gtk/o...
chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc:491: const
AutocompleteMatch& match, bool selected, bool is_selected_keyword) {
Nit: One arg per line

https://chromiumcodereview.appspot.com/9562029/diff/1/chrome/browser/ui/gtk/o...
chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc:730: kIconLeftPadding;
Nit: Indent 4

https://chromiumcodereview.appspot.com/9562029/diff/1/chrome/browser/ui/gtk/o...
File chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h (right):

https://chromiumcodereview.appspot.com/9562029/diff/1/chrome/browser/ui/gtk/o...
chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h:86: void
GetForMatch(size_t index,
Nit: Maybe this should be named GetVisibleMatchForIndex()?  Might want to
comment what it does some too

[commit-bot: I haz the power, 2012-03-01 22:23:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/9562029/5001

[commit-bot: I haz the power, 2012-03-02 01:04:47]

Change committed as 124552