Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: Source/WebCore/rendering/RenderBlock.cpp

Issue 9562023: Merge 107987 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/multicol/span/table-multi-column-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 return; 427 return;
428 } 428 }
429 429
430 RenderBlock* RenderBlock::containingColumnsBlock(bool allowAnonymousColumnBlock) 430 RenderBlock* RenderBlock::containingColumnsBlock(bool allowAnonymousColumnBlock)
431 { 431 {
432 RenderBlock* firstChildIgnoringAnonymousWrappers = 0; 432 RenderBlock* firstChildIgnoringAnonymousWrappers = 0;
433 for (RenderObject* curr = this; curr; curr = curr->parent()) { 433 for (RenderObject* curr = this; curr; curr = curr->parent()) {
434 if (!curr->isRenderBlock() || curr->isFloatingOrPositioned() || curr->is TableCell() || curr->isRoot() || curr->isRenderView() || curr->hasOverflowClip() 434 if (!curr->isRenderBlock() || curr->isFloatingOrPositioned() || curr->is TableCell() || curr->isRoot() || curr->isRenderView() || curr->hasOverflowClip()
435 || curr->isInlineBlockOrInlineTable()) 435 || curr->isInlineBlockOrInlineTable())
436 return 0; 436 return 0;
437
438 // FIXME: Table manages its own table parts, most of which are RenderBox es.
439 // Multi-column code cannot handle splitting the flow in table. Disablin g it
440 // to prevent crashes.
441 if (curr->isTable())
442 return 0;
437 443
438 RenderBlock* currBlock = toRenderBlock(curr); 444 RenderBlock* currBlock = toRenderBlock(curr);
439 if (!currBlock->createsAnonymousWrapper()) 445 if (!currBlock->createsAnonymousWrapper())
440 firstChildIgnoringAnonymousWrappers = currBlock; 446 firstChildIgnoringAnonymousWrappers = currBlock;
441 447
442 if (currBlock->style()->specifiesColumns() && (allowAnonymousColumnBlock || !currBlock->isAnonymousColumnsBlock())) 448 if (currBlock->style()->specifiesColumns() && (allowAnonymousColumnBlock || !currBlock->isAnonymousColumnsBlock()))
443 return firstChildIgnoringAnonymousWrappers; 449 return firstChildIgnoringAnonymousWrappers;
444 450
445 if (currBlock->isAnonymousColumnSpanBlock()) 451 if (currBlock->isAnonymousColumnSpanBlock())
446 return 0; 452 return 0;
(...skipping 6660 matching lines...) Expand 10 before | Expand all | Expand 10 after
7107 } 7113 }
7108 7114
7109 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject) 7115 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject)
7110 { 7116 {
7111 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x( ), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY()); 7117 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x( ), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY());
7112 } 7118 }
7113 7119
7114 #endif 7120 #endif
7115 7121
7116 } // namespace WebCore 7122 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/multicol/span/table-multi-column-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698