Add git diff python tool that outputs file:line in front of diff output.

Add git diff python tool that outputs file:line in front of diff output.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124499

[jbates, 2012-03-01 19:52:45]

thakis: ptal

[scheib, 2012-03-01 19:55:54]

Love the concept. I'm not strong enough in Python to catch any errors there. The
jist lgtm.

[Nico, 2012-03-01 21:57:13]

LGTM with some nits below.

I would've thought that this is doable with some flag instead, but couldn't find
one :-/

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide.py
File tools/git/git-diff-ide.py (right):

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:44: if line.startswith('diff ') or \
if (foo or
  bar):

is preferred over \

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:47: print line
Maybe it's easier to understand what's going on if you put a comment in each
block describing what the block handles?

E.g.

# Handle:
# diff --git a/third_party/libxml/src/pattern.c
b/third_party/libxml/src/pattern.c
# index 0e38c2d..8cd69ae 100644
# --- a/third_party/libxml/src/pattern.c

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:50: current_file = line[4:] if line[4] == '/' else
line[6:]
# Handle:
# +++ b/third_party/libxml/src/pattern.c

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:54: line_num = int(line.split()[2][1:].split(',')[0])
# Handle:
# @@ -305,7 +305,8 @@ xmlNewPatParserContext(const xmlChar *pattern, xmlDictPtr
dict,

Maybe

  _, old_nr, new_nr, _ = line.split(' ', 3)
  line_num = new_nr.split(',')[0]

is a little easier to grok?

[jbates, 2012-03-01 22:26:00]

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide.py
File tools/git/git-diff-ide.py (right):

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:44: if line.startswith('diff ') or \
On 2012/03/01 21:57:13, Nico wrote:
> if (foo or
>   bar):
> 
> is preferred over \

Done.

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:47: print line
On 2012/03/01 21:57:13, Nico wrote:
> Maybe it's easier to understand what's going on if you put a comment in each
> block describing what the block handles?
> 
> E.g.
> 
> # Handle:
> # diff --git a/third_party/libxml/src/pattern.c
> b/third_party/libxml/src/pattern.c
> # index 0e38c2d..8cd69ae 100644
> # --- a/third_party/libxml/src/pattern.c

Done.

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:50: current_file = line[4:] if line[4] == '/' else
line[6:]
On 2012/03/01 21:57:13, Nico wrote:
> # Handle:
> # +++ b/third_party/libxml/src/pattern.c

Done.

https://chromiumcodereview.appspot.com/9562011/diff/1/tools/git/git-diff-ide....
tools/git/git-diff-ide.py:54: line_num = int(line.split()[2][1:].split(',')[0])
On 2012/03/01 21:57:13, Nico wrote:
> # Handle:
> # @@ -305,7 +305,8 @@ xmlNewPatParserContext(const xmlChar *pattern,
xmlDictPtr
> dict,
> 
> Maybe
> 
>   _, old_nr, new_nr, _ = line.split(' ', 3)
>   line_num = new_nr.split(',')[0]
> 
> is a little easier to grok?

Done.

[Nico, 2012-03-01 22:27:17]

lgtm++