Respect policy for list of startup pages

Respect policy for list of startup pages

BUG=116207
TEST=set RestoreOnStartupURLs policy, list in dialog is disabled

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124689

[Tyler Breisacher (Chromium), 2012-03-01 00:15:14]

https://chromiumcodereview.appspot.com/9561006/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/startup_overlay.html (right):

https://chromiumcodereview.appspot.com/9561006/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/startup_overlay.html:7: <input type="text"
pref="session.urls_to_restore_on_startup" hidden>
This has no effect currently, but once estade commits
http://codereview.chromium.org/9513016/ it will be necessary.

[Tyler Breisacher (Chromium), 2012-03-01 00:54:22]

+estade

[csilv, 2012-03-01 01:14:59]

lgtm

[Evan Stade, 2012-03-01 17:42:42]

this doesn't completely fix the bug, right? The link is still clickable. It
should be disabled if the startup pref is managed, and set to anything besides
"list of pages".

[Tyler Breisacher (Chromium), 2012-03-01 19:06:58]

Good point. It should probably also be grayed out, or at least a "grayer" shade
of blue. Do we have a standard CSS class for "disabled" links?

[Evan Stade, 2012-03-01 22:21:36]

On 2012/03/01 19:06:58, Tyler Breisacher wrote:
> Good point. It should probably also be grayed out, or at least a "grayer"
shade
> of blue. Do we have a standard CSS class for "disabled" links?

just set the disabled property. I'll add some css to respect it visually.

[Tyler Breisacher (Chromium), 2012-03-01 22:49:37]

On 2012/03/01 22:21:36, Evan Stade wrote:
> just set the disabled property. I'll add some css to respect it visually.

Done.

[Evan Stade, 2012-03-02 03:38:35]

http://codereview.chromium.org/9561006/diff/10002/chrome/browser/resources/op...
File chrome/browser/resources/options2/browser_options.js (right):

http://codereview.chromium.org/9561006/diff/10002/chrome/browser/resources/op...
chrome/browser/resources/options2/browser_options.js:89:
startupSetPagesLink.disabled =
this indent can't be right.

http://codereview.chromium.org/9561006/diff/10002/chrome/browser/resources/op...
chrome/browser/resources/options2/browser_options.js:94: if
(!startupSetPagesLink.disabled)
is this required? disabled buttons can't be clicked...

[Tyler Breisacher (Chromium), 2012-03-02 04:10:46]

http://codereview.chromium.org/9561006/diff/10002/chrome/browser/resources/op...
File chrome/browser/resources/options2/browser_options.js (right):

http://codereview.chromium.org/9561006/diff/10002/chrome/browser/resources/op...
chrome/browser/resources/options2/browser_options.js:89:
startupSetPagesLink.disabled =
Is this better?

http://codereview.chromium.org/9561006/diff/10002/chrome/browser/resources/op...
chrome/browser/resources/options2/browser_options.js:94: if
(!startupSetPagesLink.disabled)
I forgot it's actually a button, not a link. Done.

[Evan Stade, 2012-03-02 17:26:32]

lgtm

http://codereview.chromium.org/9561006/diff/13002/chrome/browser/resources/op...
File chrome/browser/resources/options2/browser_options.js (right):

http://codereview.chromium.org/9561006/diff/13002/chrome/browser/resources/op...
chrome/browser/resources/options2/browser_options.js:87: function(event) {
I honestly don't know what the correct indentation is. This seems ok. I guess
the last version you had wasn't bad either. Or maybe make the function(event)
line flush with the first argument, and the body indented by 2 instead of 6.