Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9561003: ash uber tray: Add a tray item for the user. (Closed)

Created:
8 years, 9 months ago by sadrul
Modified:
8 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

ash uber tray: Add a tray item for the user. The item includes the logged in users name/email, and buttons to shut-down/signout/lock. BUG=110130 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124368

Patch Set 1 #

Patch Set 2 : user-avatar in the tray #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : const #

Patch Set 5 : GetUserDisplayName instead of GetUserName #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -6 lines) Patch
M ash/ash.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 chunks +25 lines, -5 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
A ash/system/tray_user.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ash/system/tray_user.cc View 1 2 3 4 1 chunk +160 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 3 4 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
8 years, 9 months ago (2012-02-29 23:16:09 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-02-29 23:33:53 UTC) #2
tfarina
http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_delegate.h File ash/system/tray/system_tray_delegate.h (right): http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_delegate.h#newcode18 ash/system/tray/system_tray_delegate.h:18: virtual std::string GetUserName() = 0; nit: could you make ...
8 years, 9 months ago (2012-03-01 00:46:23 UTC) #3
sadrul
http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_delegate.h File ash/system/tray/system_tray_delegate.h (right): http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_delegate.h#newcode18 ash/system/tray/system_tray_delegate.h:18: virtual std::string GetUserName() = 0; On 2012/03/01 00:46:23, tfarina ...
8 years, 9 months ago (2012-03-01 01:35:10 UTC) #4
tfarina
On 2012/03/01 01:35:10, sadrul wrote: > http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_delegate.h > File ash/system/tray/system_tray_delegate.h (right): > > http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_delegate.h#newcode18 > ...
8 years, 9 months ago (2012-03-01 16:59:21 UTC) #5
sadrul
8 years, 9 months ago (2012-03-01 17:18:56 UTC) #6 
On 2012/03/01 16:59:21, tfarina wrote:
> On 2012/03/01 01:35:10, sadrul wrote:
> >
>
http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_...
> > File ash/system/tray/system_tray_delegate.h (right):
> > 
> >
>
http://codereview.chromium.org/9561003/diff/2001/ash/system/tray/system_tray_...
> > ash/system/tray/system_tray_delegate.h:18: virtual std::string GetUserName()
=
> > 0;
> > On 2012/03/01 00:46:23, tfarina wrote:
> > > nit: could you make these three new methods const?
> > 
> > Done.
> 
> I meant "virtual std::string GetFoo() const = 0;" to make the function const.

Why? I don't think that is necessary/useful.

> "virtual const std::string GetFoo() const = 0;" is even better because it also
> makes the return type const.
> 
> I'll send a CL for review soon.

Powered by Google App Engine
This is Rietveld 408576698