Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9560005: [uber page] Merge advanced options page into browser options. (Closed)

Created:
8 years, 9 months ago by csilv
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Merge advanced options page into browser options. This CL merges the AdvancedOptions handler into BrowserOptions. There remains additional cleanup to remove subpage support from the options page that I intend to handle in a followup CL. The focus here is to match the mocks and retain all functionality. As a result of this change, searching works considerably better. BUG=116107, 110527, 111645 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124470

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Code review change, rebase. #

Patch Set 3 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1811 lines, -2059 lines) Patch
M chrome/app/generated_resources.grd View 1 2 4 chunks +6 lines, -11 lines 0 comments Download
D chrome/browser/resources/options2/advanced_options.css View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/options2/advanced_options.html View 1 2 1 chunk +0 lines, -328 lines 0 comments Download
D chrome/browser/resources/options2/advanced_options.js View 1 2 1 chunk +0 lines, -464 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.css View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.html View 1 2 3 chunks +331 lines, -9 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.js View 1 2 8 chunks +511 lines, -20 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/resources/options2/options.js View 1 2 7 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/options_page.css View 1 2 3 chunks +1 line, -64 lines 0 comments Download
M chrome/browser/resources/options2/password_manager.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/search_page.js View 1 2 3 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/resources/uber/uber_shared.css View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
D chrome/browser/ui/webui/options2/advanced_options2_browsertest.js View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ui/webui/options2/advanced_options_handler2.h View 1 2 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/browser/ui/webui/options2/advanced_options_handler2.cc View 1 2 1 chunk +0 lines, -809 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.h View 1 2 5 chunks +163 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 1 2 20 chunks +694 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/options2_browsertest.js View 1 2 3 chunks +26 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
csilv
+jhawkins for review It's big, but most of this is just moving code from advanced ...
8 years, 9 months ago (2012-03-01 01:03:42 UTC) #1
csilv
https://chromiumcodereview.appspot.com/9560005/diff/1030/chrome/browser/resources/options2/search_page.js File chrome/browser/resources/options2/search_page.js (left): https://chromiumcodereview.appspot.com/9560005/diff/1030/chrome/browser/resources/options2/search_page.js#oldcode279 chrome/browser/resources/options2/search_page.js:279: this.dispatchEvent(event); FYI, this bit is obsolete... removed.
8 years, 9 months ago (2012-03-01 02:55:20 UTC) #2
James Hawkins
LGTM with nit. https://chromiumcodereview.appspot.com/9560005/diff/1030/chrome/browser/resources/options2/browser_options.html File chrome/browser/resources/options2/browser_options.html (right): https://chromiumcodereview.appspot.com/9560005/diff/1030/chrome/browser/resources/options2/browser_options.html#newcode276 chrome/browser/resources/options2/browser_options.html:276: <div id="advanced-settings" style="height: 0px;"> nit: No ...
8 years, 9 months ago (2012-03-01 12:15:32 UTC) #3
csilv
8 years, 9 months ago (2012-03-01 18:12:52 UTC) #4 
https://chromiumcodereview.appspot.com/9560005/diff/1030/chrome/browser/resou...
File chrome/browser/resources/options2/browser_options.html (right):

https://chromiumcodereview.appspot.com/9560005/diff/1030/chrome/browser/resou...
chrome/browser/resources/options2/browser_options.html:276: <div
id="advanced-settings" style="height: 0px;">
On 2012/03/01 12:15:33, James Hawkins wrote:
> nit: No styling in the HTML.

Done.

Powered by Google App Engine
This is Rietveld 408576698