chrome/browser/ui/panels/panel_overflow_browsertest.cc - Issue 9560002: Cleanup to keep panel from manipulating its panel strip assignment directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_overflow_browsertest.cc

Issue 9560002: Cleanup to keep panel from manipulating its panel strip assignment directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed final nits Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/panels/panel_overflow_browsertest.cc

diff --git a/chrome/browser/ui/panels/panel_overflow_browsertest.cc b/chrome/browser/ui/panels/panel_overflow_browsertest.cc

index 7b50a7e72ff2b4cd5bfabb04a05d62134f493491..5d329b0cd21812f3915b3fc5c199122a3aa1e06e 100644

--- a/chrome/browser/ui/panels/panel_overflow_browsertest.cc

+++ b/chrome/browser/ui/panels/panel_overflow_browsertest.cc

@@ -254,9 +254,9 @@ IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest, UpdateDraggableStatus) {

PanelManager* panel_manager = PanelManager::GetInstance();

Panel* panel = CreatePanel("panel");

EXPECT_TRUE(panel->draggable());

- panel->MoveToStrip(panel_manager->overflow_strip());

+ panel_manager->MovePanelToStrip(panel, PanelStrip::IN_OVERFLOW);

EXPECT_FALSE(panel->draggable());

- panel->MoveToStrip(panel_manager->docked_strip());

+ panel_manager->MovePanelToStrip(panel, PanelStrip::DOCKED);

EXPECT_TRUE(panel->draggable());

panel->Close();

}

« no previous file with comments | « chrome/browser/ui/panels/panel_manager.cc ('k') | chrome/browser/ui/panels/panel_strip.h » ('j') | no next file with comments »