chrome/browser/ui/panels/detached_panel_strip.h - Issue 9560002: Cleanup to keep panel from manipulating its panel strip assignment directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/detached_panel_strip.h

Issue 9560002: Cleanup to keep panel from manipulating its panel strip assignment directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed final nits Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/panels/detached_panel_strip.h

diff --git a/chrome/browser/ui/panels/detached_panel_strip.h b/chrome/browser/ui/panels/detached_panel_strip.h

index 4ea0c4f64b19c568206802f4502588e7f36aaeeb..0beedf94ab9f25c37ad97220ab9a846c0a94b57c 100644

--- a/chrome/browser/ui/panels/detached_panel_strip.h

+++ b/chrome/browser/ui/panels/detached_panel_strip.h

@@ -28,7 +28,7 @@ class DetachedPanelStrip : public PanelStrip {

virtual void SetDisplayArea(const gfx::Rect& display_area) OVERRIDE;

virtual void RefreshLayout() OVERRIDE;

virtual void AddPanel(Panel* panel) OVERRIDE;

- virtual bool RemovePanel(Panel* panel) OVERRIDE;

+ virtual void RemovePanel(Panel* panel) OVERRIDE;

virtual void CloseAll() OVERRIDE;

virtual void ResizePanelWindow(

Panel* panel,

@@ -37,6 +37,7 @@ class DetachedPanelStrip : public PanelStrip {

virtual void ActivatePanel(Panel* panel) OVERRIDE;

virtual void MinimizePanel(Panel* panel) OVERRIDE;

virtual void RestorePanel(Panel* panel) OVERRIDE;

+ virtual bool IsPanelMinimized(const Panel* panel) const OVERRIDE;

virtual bool CanShowPanelAsActive(const Panel* panel) const OVERRIDE;

virtual bool CanDragPanel(const Panel* panel) const OVERRIDE;

virtual void StartDraggingPanel(Panel* panel) OVERRIDE;

« no previous file with comments | « chrome/browser/ui/panels/detached_panel_browsertest.cc ('k') | chrome/browser/ui/panels/detached_panel_strip.cc » ('j') | no next file with comments »