Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: chrome/browser/ui/panels/panel_manager.h

Issue 9560002: Cleanup to keep panel from manipulating its panel strip assignment directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more feedback changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_manager.h
diff --git a/chrome/browser/ui/panels/panel_manager.h b/chrome/browser/ui/panels/panel_manager.h
index d02fe76d8b9d30282cdf61eed5ffd7ffea9a1d8a..05d5c1c97d129743ae80add4106c7711f6b32e31 100644
--- a/chrome/browser/ui/panels/panel_manager.h
+++ b/chrome/browser/ui/panels/panel_manager.h
@@ -13,6 +13,7 @@
#include "base/timer.h"
#include "chrome/browser/ui/panels/auto_hiding_desktop_bar.h"
#include "chrome/browser/ui/panels/panel.h"
+#include "chrome/browser/ui/panels/panel_strip.h"
#include "ui/gfx/rect.h"
class Browser;
@@ -61,6 +62,15 @@ class PanelManager : public AutoHidingDesktopBar::Observer {
// for panels that are auto-sized.
void ResizePanel(Panel* panel, const gfx::Size& new_size);
+ // Moves the |panel| to a different type of panel strip.
+ void MovePanelToStrip(Panel* panel, PanelStrip::Type new_layout);
+
+ // Move all panels up to, and including, the |last_panel_to_move| to overflow.
+ void MovePanelsToOverflow(Panel* last_panel_to_move);
+
+ // Moves as many panels out of overflow as space allows.
+ void MovePanelsOutOfOverflowIfCanFit();
+
// Returns true if we should bring up the titlebars, given the current mouse
// point.
bool ShouldBringUpTitlebars(int mouse_x, int mouse_y) const;
@@ -206,6 +216,9 @@ class PanelManager : public AutoHidingDesktopBar::Observer {
// True if current active app is in full screen mode.
bool is_full_screen_;
+ // True only while moving panels to overflow.
jianli 2012/03/02 22:25:32 nit: Please comment why we need this flag, like we
jennb 2012/03/02 22:44:37 Done.
+ bool is_processing_overflow_;
+
DISALLOW_COPY_AND_ASSIGN(PanelManager);
};

Powered by Google App Engine
This is Rietveld 408576698