Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2967)

Unified Diff: chrome/browser/metrics/metrics_log.h

Issue 9559017: [UMA] Include field trial tuples in the UMA upload. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mock out scree size/count code for testing Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_log.h
diff --git a/chrome/browser/metrics/metrics_log.h b/chrome/browser/metrics/metrics_log.h
index 5935139a58133d6e8119b08d9ab250e35254c7f8..977c09f6e576a5f0efcc1610e60de1d0337fed1e 100644
--- a/chrome/browser/metrics/metrics_log.h
+++ b/chrome/browser/metrics/metrics_log.h
@@ -13,7 +13,9 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/metrics/field_trial.h"
#include "chrome/common/metrics/metrics_log_base.h"
+#include "ui/gfx/size.h"
struct AutocompleteLog;
class PrefService;
@@ -71,6 +73,23 @@ class MetricsLog : public MetricsLogBase {
void RecordIncrementalStabilityElements(
const std::vector<webkit::WebPluginInfo>& plugin_list);
+ protected:
+ // Exposed for the sake of mocking in test code.
+
+ // Returns the PrefService from which to log metrics data.
+ virtual PrefService* GetPrefService();
+
+ // Returns the screen size for the primary monitor.
+ virtual gfx::Size GetScreenSize() const;
+
+ // Returns the number of monitors the user is using.
+ virtual int GetScreenCount() const;
+
+ // Fills |field_trial_ids| with the list of initialized field trials name and
+ // group ids.
+ virtual void GetFieldTrialIds(
+ std::vector<base::FieldTrial::NameGroupId>* field_trial_ids) const;
+
private:
FRIEND_TEST_ALL_PREFIXES(MetricsLogTest, ChromeOSStabilityData);
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698