Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5026)

Unified Diff: chrome/browser/prefs/session_startup_pref_unittest.cc

Issue 9559002: Bug 111139: Deprecate HOMEPAGE option, remove the UI for it, migrate users away from it (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/session_startup_pref_unittest.cc
diff --git a/chrome/browser/prefs/session_startup_pref_unittest.cc b/chrome/browser/prefs/session_startup_pref_unittest.cc
index 7a0e44bf30d3109ebe0eaffd3ab0775be3b7dbc4..e5e1fde09dbdeb646aeb4403ac59caa0e24ced17 100644
--- a/chrome/browser/prefs/session_startup_pref_unittest.cc
+++ b/chrome/browser/prefs/session_startup_pref_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -56,3 +56,19 @@ TEST_F(SessionStartupPrefTest, URLListManagedOverridesUser) {
result = SessionStartupPref::GetStartupPref(pref_service_.get());
EXPECT_EQ(3u, result.urls.size());
}
+
+TEST_F(SessionStartupPrefTest, HomePageMigration) {
+ pref_service_->RegisterStringPref(prefs::kHomePage, "http://google.com/");
+
+ // By design, it's impossible to set the 'restore on startup' pref to 0
+ // ("open the homepage") using SessionStartupPref::SetStartupPref(), so set it
+ // using the pref service directly.
+ pref_service_->SetInteger(prefs::kRestoreOnStartup, /*kPrefValueHomePage*/ 0);
+ pref_service_->SetString(prefs::kHomePage, "http://chromium.org/");
+
+ SessionStartupPref pref = SessionStartupPref::GetStartupPref(
+ pref_service_.get());
+ EXPECT_EQ(SessionStartupPref::URLS, pref.type);
+ EXPECT_EQ(1U, pref.urls.size());
+ EXPECT_EQ(GURL("http://chromium.org/"), pref.urls[0]);
+}

Powered by Google App Engine
This is Rietveld 408576698