Issue 9559002: Bug 111139: Deprecate HOMEPAGE option, remove the UI for it, migrate users away from it

Issue 9559002: Bug 111139: Deprecate HOMEPAGE option, remove the UI for it, migrate users away from it (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 9 months ago

Reviewers:
csilv, Ben Goodger (Google)

CC:
chromium-reviews, arv (Not doing code reviews), Dan Beam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Bug 111139: Deprecate HOMEPAGE option, remove the UI for it, migrate users away from it BUG=111139 TEST=SessionStartupPrefTest.HomePageMigration TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124583

Patch Set 2 : rebase #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -29 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/prefs/session_startup_pref.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/session_startup_pref.cc	View		4 chunks	+19 lines, -2 lines	2 comments	Download
M	chrome/browser/prefs/session_startup_pref_unittest.cc	View		2 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options2/browser_options.html	View	1	2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/browser_options_handler2.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tyler Breisacher (Chromium)

TBR'ing Ben as this the same change that was previously lgtm'd and committed.

8 years, 9 months ago (2012-03-02 03:31:02 UTC) #2

Dan Beam

https://chromiumcodereview.appspot.com/9559002/diff/5001/chrome/browser/prefs/session_startup_pref.cc File chrome/browser/prefs/session_startup_pref.cc (right): https://chromiumcodereview.appspot.com/9559002/diff/5001/chrome/browser/prefs/session_startup_pref.cc#newcode115 chrome/browser/prefs/session_startup_pref.cc:115: if (pref.type == SessionStartupPref::HOMEPAGE) { how does one ever ...

8 years, 9 months ago (2012-03-02 22:18:08 UTC) #3

Tyler Breisacher (Chromium)

8 years, 9 months ago (2012-03-02 22:35:54 UTC) #4

https://chromiumcodereview.appspot.com/9559002/diff/5001/chrome/browser/prefs...
File chrome/browser/prefs/session_startup_pref.cc (right):

https://chromiumcodereview.appspot.com/9559002/diff/5001/chrome/browser/prefs...
chrome/browser/prefs/session_startup_pref.cc:115: if (pref.type ==
SessionStartupPref::HOMEPAGE) {
On 2012/03/02 22:18:08, Dan Beam wrote:
> how does one ever delete this code?

If all users have upgraded to a version that has this change, and opened Chrome
at least once, then it should be safe to delete this. If we wanted to get rid of
this in, say, Chrome 20, then I think the only risk would be someone who
installed, say, Chrome 17, then upgraded to Chrome 20 without ever opening
Chrome 18 or Chrome 19. What do you suggest?

Expand Messages | Collapse Messages