Rename content/{common,browser}/file_system to fileapi and move blob stuff into it.

Rename content/{common,browser}/file_system to fileapi and move blob stuff into it.


This patch:
 - renames content/{common,browser]/file_system to content/{common,browser}/fileapi,
 - moves content/browser/chrome_blob_storage_context.{h,cc} into content/browser/fileapi,
 - moves content/common/webblob_registry_impl.{h,cc} into content/common/fileapi,
 - moves content/common/{file_system_messages.h,webblob_messages.h} into content/common/fileapi,
 - adds jianli@ to OWNERS of content/{browser,common}/fileapi,
 - rename FileAndBlobMessageFilter to FileAPIMessageFilter.

BUG=115603
TEST='Build should finish successfully'


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124439

[michaeln, 2012-02-29 23:02:22]

you get to rebase this time around :)

[kinuko, 2012-03-01 01:10:33]

lgtm

[jam, 2012-03-01 01:12:56]

lgtm

http://codereview.chromium.org/9558006/diff/3010/content/browser/fileapi/file...
File content/browser/fileapi/file_and_blob_message_filter.h (right):

http://codereview.chromium.org/9558006/diff/3010/content/browser/fileapi/file...
content/browser/fileapi/file_and_blob_message_filter.h:42: class
FileAndBlobMessageFilter : public content::BrowserMessageFilter {
nit: perhaps rename this to FileAPIFilter? FileAndBlobMessgeFilter is a little
awkward

[kinuko, 2012-03-01 01:14:50]

http://codereview.chromium.org/9558006/diff/3010/content/browser/fileapi/file...
File content/browser/fileapi/file_and_blob_message_filter.h (right):

http://codereview.chromium.org/9558006/diff/3010/content/browser/fileapi/file...
content/browser/fileapi/file_and_blob_message_filter.h:42: class
FileAndBlobMessageFilter : public content::BrowserMessageFilter {
On 2012/03/01 01:12:56, John Abd-El-Malek wrote:
> nit: perhaps rename this to FileAPIFilter? FileAndBlobMessgeFilter is a little
> awkward

I was about to suggest the same... sgtm.

[tzik, 2012-03-01 02:08:55]

http://codereview.chromium.org/9558006/diff/3010/content/browser/fileapi/file...
File content/browser/fileapi/file_and_blob_message_filter.h (right):

http://codereview.chromium.org/9558006/diff/3010/content/browser/fileapi/file...
content/browser/fileapi/file_and_blob_message_filter.h:42: class
FileAndBlobMessageFilter : public content::BrowserMessageFilter {
On 2012/03/01 01:12:56, John Abd-El-Malek wrote:
> nit: perhaps rename this to FileAPIFilter? FileAndBlobMessgeFilter is a little
> awkward

Sounds great. Done.

[kinuko, 2012-03-01 02:12:06]

http://codereview.chromium.org/9558006/diff/2062/content/browser/fileapi/file...
File content/browser/fileapi/file_api_message_filter.h (right):

http://codereview.chromium.org/9558006/diff/2062/content/browser/fileapi/file...
content/browser/fileapi/file_api_message_filter.h:6: #define
CONTENT_BROWSER_FILEAPI_FILE_API_MESSAGE_FILTER_H_
Hmm, since we usually write just 'fileapi' (without _) shouldn't we simply name
this fileapi_message_filter.{cc,h} rather than file_api_.. ?

[tzik, 2012-03-01 02:20:12]

http://codereview.chromium.org/9558006/diff/2062/content/browser/fileapi/file...
File content/browser/fileapi/file_api_message_filter.h (right):

http://codereview.chromium.org/9558006/diff/2062/content/browser/fileapi/file...
content/browser/fileapi/file_api_message_filter.h:6: #define
CONTENT_BROWSER_FILEAPI_FILE_API_MESSAGE_FILTER_H_
On 2012/03/01 02:12:06, kinuko wrote:
> Hmm, since we usually write just 'fileapi' (without _) shouldn't we simply
name
> this fileapi_message_filter.{cc,h} rather than file_api_.. ?

Done.

[michaeln, 2012-03-01 05:53:57]

renaming/moving lgtm, please run try jobs

[tzik, 2012-03-01 07:14:15]

On 2012/03/01 05:53:57, michaeln wrote:
> renaming/moving lgtm, please run try jobs

Thanks! Now, try jobs are running.

[commit-bot: I haz the power, 2012-03-01 17:25:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/9558006/12001

[commit-bot: I haz the power, 2012-03-01 19:08:23]

Change committed as 124439

[jam, 2013-02-01 03:10:38]

https://codereview.chromium.org/9558006/diff/12001/content/browser/fileapi/br...
File content/browser/fileapi/browser_file_system_helper.cc (right):

https://codereview.chromium.org/9558006/diff/12001/content/browser/fileapi/br...
content/browser/fileapi/browser_file_system_helper.cc:22: const char
kExtensionScheme[] = "chrome-extension";
I just saw this while looking through the code. this a layering violation, since
content shouldn't know about chrome

[kinuko, 2013-02-01 03:33:16]

On 2013/02/01 03:10:38, jam wrote:
>
https://codereview.chromium.org/9558006/diff/12001/content/browser/fileapi/br...
> File content/browser/fileapi/browser_file_system_helper.cc (right):
> 
>
https://codereview.chromium.org/9558006/diff/12001/content/browser/fileapi/br...
> content/browser/fileapi/browser_file_system_helper.cc:22: const char
> kExtensionScheme[] = "chrome-extension";
> I just saw this while looking through the code. this a layering violation,
since
> content shouldn't know about chrome

I just filed a bug: http://crbug.com/173574
We also have chrome_blob_storage_context.{cc,h} here... (it's created when we
were in chrome/).

[jam, 2013-02-01 03:37:46]

On 2013/02/01 03:33:16, kinuko wrote:
> On 2013/02/01 03:10:38, jam wrote:
> >
>
https://codereview.chromium.org/9558006/diff/12001/content/browser/fileapi/br...
> > File content/browser/fileapi/browser_file_system_helper.cc (right):
> > 
> >
>
https://codereview.chromium.org/9558006/diff/12001/content/browser/fileapi/br...
> > content/browser/fileapi/browser_file_system_helper.cc:22: const char
> > kExtensionScheme[] = "chrome-extension";
> > I just saw this while looking through the code. this a layering violation,
> since
> > content shouldn't know about chrome
> 
> I just filed a bug: http://crbug.com/173574
> We also have chrome_blob_storage_context.{cc,h} here... (it's created when we
> were in chrome/).

thanks :) I've commented on the bug.