Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: dart/frog/leg/ssa/builder.dart

Issue 9558005: Implement literal maps. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/resolver.dart ('k') | dart/frog/leg/ssa/closure.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/ssa/builder.dart
diff --git a/dart/frog/leg/ssa/builder.dart b/dart/frog/leg/ssa/builder.dart
index 9db538b274b2a99adeeb0344025f2d09cbd55fff..cd79469ea602e2ed3a07858a01935bec4ac5753a 100644
--- a/dart/frog/leg/ssa/builder.dart
+++ b/dart/frog/leg/ssa/builder.dart
@@ -93,6 +93,10 @@ class Interceptors {
Element getExceptionUnwrapper() {
return compiler.findHelper(const SourceString('unwrapException'));
}
+
+ Element getMapMaker() {
+ return compiler.findHelper(const SourceString('makeLiteralMap'));
+ }
}
class SsaBuilderTask extends CompilerTask {
@@ -2236,11 +2240,25 @@ class SsaBuilder implements Visitor {
}
visitLiteralMap(LiteralMap node) {
- generateUnimplemented('literal map not implemented', isExpression: true);
+ List<HInstruction> inputs = <HInstruction>[];
+ for (Link<Node> link = node.entries.nodes;
+ !link.isEmpty();
+ link = link.tail) {
+ visit(link.head);
+ inputs.addLast(pop());
+ inputs.addLast(pop());
+ }
+ HLiteralList keyValuePairs = new HLiteralList(inputs, node.isConst());
+ HStatic mapMaker = new HStatic(interceptors.getMapMaker());
+ add(keyValuePairs);
+ add(mapMaker);
+ inputs = <HInstruction>[mapMaker, keyValuePairs];
+ push(new HInvokeStatic(Selector.INVOCATION_1, inputs));
}
visitLiteralMapEntry(LiteralMapEntry node) {
- compiler.unimplemented('SsaBuilder.visitLiteralMapEntry', node: node);
+ visit(node.value);
+ visit(node.key);
}
visitNamedArgument(NamedArgument node) {
« no previous file with comments | « dart/frog/leg/resolver.dart ('k') | dart/frog/leg/ssa/closure.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698